From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 57C9749149 for ; Tue, 5 Mar 2024 14:54:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E345668D025; Tue, 5 Mar 2024 16:54:26 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 110BF68CD06 for ; Tue, 5 Mar 2024 16:54:20 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=G/s9x/3h; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id CAA1C24048D for ; Tue, 5 Mar 2024 15:54:19 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id TiQNAqrE-5lq for ; Tue, 5 Mar 2024 15:54:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1709650458; bh=8bdH/7Oyo99RdWuCboDd4fDoALNeh7XbYRRebm3ICOw=; h=Subject:From:To:In-Reply-To:References:Date:From; b=G/s9x/3hDkoU7N1qzw7G5jZGDJK9zJNaoetraRZCRxQJNOcvZFUKaNxd6KJ86W2GC ZZYFRnyzj1ZCr/suX9deyE4d6YMPE90smPnyzLQ+ZEungZ+2whDT3pY745q+I5BkEZ crZ0lv0mM9PkLJ9dJmR/SqniwIRQgG/PnLKMNdmvCZhjd/vy5BIUE2xHLe84ciYFrq gO42fTPWKwtIx/87C7c2o4SBxy6DZnzL/qQmEfWkVTWUHONiRQ+zHcHKKd50hUZ6GU AlSObYp7wF/2c+Yw9swS6jIS1KECe6nMSki+Ma85yRDC1HBkVR9POkJ4Bn+G3m0GIT uY1iFot0EhvQw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id DE42F240177 for ; Tue, 5 Mar 2024 15:54:18 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id BE68B1601B9; Tue, 5 Mar 2024 15:54:18 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <8bf41fe7-a9f9-4ae4-abfc-31117ddae687@gmail.com> References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-7-anton@khirnov.net> <6aeedda4-c8a7-4c4c-a33d-d2225508eeeb@gmail.com> <170964899292.29002.12504993650425451482@lain.khirnov.net> <8bf41fe7-a9f9-4ae4-abfc-31117ddae687@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 05 Mar 2024 15:54:18 +0100 Message-ID: <170965045875.29002.15043263301458990476@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-03-05 15:35:02) > On 3/5/2024 11:29 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-03-05 13:30:58) > >>> + {"dynamic_hdr10_plus", .default_val.i64 = AV_PKT_DATA_DYNAMIC_HDR10_PLUS, .type = AV_OPT_TYPE_CONST, .flags = A|D, .unit = "side_data_pkt" }, > >> > >> This one packet/frame level only, not global. > > > > It is in sd_global_map > > Then that's a mistake, and I'm probably he culprit. HDR10+ is per frame > metadata. Static HDR metadata are mastering_display and ccl. Ok, dropped from the options table locally. > > > > >> Is this option meant to also choose which one of those to use? > > > > ??? > > You can have packet side data at the container level that corresponds to > the same thinga per frame side data at the bitstream level does. In > HDR10+ case, Matroska may have it in block additional, and then afaik it > could be present in the hevc bitstream. > One of them should have priority, or the user could be given the choice. Right, I've thought about this a bit, but then couldn't find any side data types that some container could export per-packet AND could also be present in the bitstream. One possible solution is to rename the option to something like side_data_prefer_external (better names welcome), and have it switch between user-supplied (i.e. global or per-packet) and in-bitstream side data. This adds an ambiguity for the hypothetical case where some side data exists as global and per-packet - then I'd say lavc should default to per-packet and leave the other case to the caller (should be very rare, possibly could be handled with a bitstream filter). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".