From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D3C6D484B1 for ; Tue, 5 Mar 2024 09:57:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 06BE268CF79; Tue, 5 Mar 2024 11:57:41 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D71A568CD00 for ; Tue, 5 Mar 2024 11:57:34 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=deLwjVlm; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 946DF24048D for ; Tue, 5 Mar 2024 10:57:34 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id GXJkoGGXt7nO for ; Tue, 5 Mar 2024 10:57:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1709632654; bh=tgulNwqVY1Vw5qCdWEZrLkVPx0JSQ4GLy/uNLKS/534=; h=Subject:From:To:In-Reply-To:References:Date:From; b=deLwjVlmqy39QFJdl59+MUvaWuWgRYYQWJCIBj87fqO9BrM64D3RuuMXg9arknLja IWT4TRbiUQB5RGD/j23O2gsau3T/LY7cjj+F447FO9GAdekAvCazh1UXChotlsgEmT AoNR4b0gMwI/h1za4JIBzj4Xp51WhvvO1dr4wozQQeLlM5Q/3VpjA41B0r08nkxURG mA55pq+M6B8PPHsFpLVcJ7vUuiRWOJnWosVnL1PkK5UnEk33znOFfgHRPpz4NyCPmK l6nfpbyollXs+g9QnS80KboUfQlJtSTibn5AWBEXJk6w9mOcpPydbZeh3LAQKWuOF1 mdJOcEeFILF8w== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0CC0D240177 for ; Tue, 5 Mar 2024 10:57:34 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id E0ECE1601B9; Tue, 5 Mar 2024 10:57:33 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-7-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 05 Mar 2024 10:57:33 +0100 Message-ID: <170963265389.29002.3535459185964911559@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 07/29] lavc: add a decoder option for configuring side data preference X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Derek Buitenhuis (2024-03-04 15:05:29) > On 3/4/2024 1:06 PM, Anton Khirnov wrote: > > + /** > > + * Decoding only. May be set by the caller before avcodec_open2() to an > > + * av_malloc()'ed array (or via AVOptions). Owned and freed by the decoder > > + * afterwards. > > + * > > + * By default, when some side data type is present both in global > > + * user-supplied coded_side_data and inside the coded bitstream, avcodec > > + * will propagate the latter to the decoded frame. > > + * > > + * This array contains a list of AVPacketSideDataType for which this > > + * preference should be switched, i.e. avcodec will prefer global side data > > + * over those in stored in the bytestream. It may also contain a single -1, > > + * in which case the preference is switched for all side data types. > > + */ > > + int *side_data_prefer_global; > > My only comment is that it would be nice to include some text about what the practical > application of this option is, rather than just technical details. Something like: > > This can be useful, when, for example, input contains data in both the container > and bitstream. Added text to that effect locally. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".