From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B685B43DB9 for ; Tue, 5 Mar 2024 09:50:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 587B168CF38; Tue, 5 Mar 2024 11:50:15 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7535068C769 for ; Tue, 5 Mar 2024 11:50:09 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=RhWS8+9U; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3B45C24048D for ; Tue, 5 Mar 2024 10:50:09 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id AsTpUwiuh4yz for ; Tue, 5 Mar 2024 10:50:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1709632208; bh=E3iXMFcX3435Dqi3ot1g5UyQkyX8iJIP4KwLv8f1lD4=; h=Subject:From:To:In-Reply-To:References:Date:From; b=RhWS8+9UGxLM2Xd4UpOh4FgBwYALxLRO6gcXTo9Ni4MKtRnVB4jKGQ453kh3iPlFp XA5nKb/39v++oz7WVs2hTaBryA6XbpPXvbeL4r+o6Poj9YxaDTeGShbqohix3RFUW2 YGSywmxujyWoVB5JvIon7EpcLO7JBajA+w+3YBPypmyQueDhjFmz7NDyyAhj6AWT89 +tb6z0fCICwZXNnHSXsH6QMf6uA2ji5+jaKQnpf80PkITv/vS10DI7Q2jX13wTXSVM aR8bPZvc9Afzz+vPubcxRDfBS0Nr5EuONwqkLIsnG1TZ424e4dLwFc57JbGuCWGle0 4ZGwkvae6ld9Q== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7CA96240177 for ; Tue, 5 Mar 2024 10:50:08 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 5802A1601B9; Tue, 5 Mar 2024 10:50:08 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <2fecfdba-e1c5-3071-198a-51d17c3e42a2@passwd.hu> References: <20240304130657.30631-1-anton@khirnov.net> <20240304130657.30631-6-anton@khirnov.net> <2fecfdba-e1c5-3071-198a-51d17c3e42a2@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 05 Mar 2024 10:50:08 +0100 Message-ID: <170963220833.29002.17841076777821633386@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 06/29] lavu/opt: add array options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-03-04 22:32:21) > > @@ -330,6 +380,14 @@ typedef struct AVOption { > > const char *str; > > /* TODO those are unused now */ > > AVRational q; > > + > > + /** > > + * Used for AV_OPT_TYPE_FLAG_ARRAY options. May be NULL. > > This contradicts with the documentation of AVOptionArrayDef above, because > there you write that default_val MUST be set. Changed 'must' to 'may' locally. It is optional, and one of the test entries does not set it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".