Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marth64 <marth64@proxyid.net>
Subject: Re: [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread
Date: Fri, 16 Feb 2024 12:38:43 +0100
Message-ID: <170808352333.21676.5287948327752942736@lain.khirnov.net> (raw)
In-Reply-To: <20240211180917.1675603-1-marth64@proxyid.net>

Quoting Marth64 (2024-02-11 19:09:16)
> +static int dvdvideo_video_stream_add(AVFormatContext *s,
> +                                     DVDVideoVTSVideoStreamEntry *entry,
> +                                     enum AVStreamParseType need_parsing)
> +{
> +    AVStream *st;
> +    FFStream *sti;
> +
> +    st = avformat_new_stream(s, NULL);
> +    if (!st)
> +        return AVERROR(ENOMEM);
> +
> +    st->id = entry->startcode;
> +    st->codecpar->codec_type = AVMEDIA_TYPE_VIDEO;
> +    st->codecpar->codec_id = entry->codec_id;
> +    st->codecpar->width = entry->width;
> +    st->codecpar->height = entry->height;
> +    st->codecpar->format = AV_PIX_FMT_YUV420P;
> +    st->codecpar->color_range = AVCOL_RANGE_MPEG;
> +
> +    st->codecpar->framerate = entry->framerate;

Demuxers are not supposed to set this, it's for the codec-layer
framerate information.

> +#if FF_API_R_FRAME_RATE
> +    st->r_frame_rate = entry->framerate;
> +#endif
> +    st->avg_frame_rate = entry->framerate;
> +
> +    sti = ffstream(st);
> +    sti->request_probe = 0;
> +    sti->need_parsing = need_parsing;
> +    sti->display_aspect_ratio = entry->dar;
> +    sti->avctx->framerate = entry->framerate;

This neither.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-02-16 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11 18:09 Marth64
2024-02-11 18:09 ` [FFmpeg-devel] [PATCH v13 2/2] libavformat/dvdvideo: add CLUT utilities and enable subtitle palette support Marth64
2024-02-12 15:47 ` [FFmpeg-devel] [PATCH v13 1/2] libavformat: add DVD-Video demuxer, powered by libdvdnav and libdvdread Stefano Sabatini
2024-02-12 15:59   ` Marth64
2024-02-16 11:38 ` Anton Khirnov [this message]
2024-02-16 15:52   ` Marth64

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170808352333.21676.5287948327752942736@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=marth64@proxyid.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git