From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B77B749663 for ; Thu, 15 Feb 2024 16:20:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B3AD68D261; Thu, 15 Feb 2024 18:20:09 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A41EC68D1DA for ; Thu, 15 Feb 2024 18:20:02 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=U+UKKizX; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 56C6E240DA9 for ; Thu, 15 Feb 2024 17:20:02 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id bFSCMqTl2oqi for ; Thu, 15 Feb 2024 17:20:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1708014001; bh=yq+PwrjYijhkwOzj9nKUM3lpRCExAAXCWZfv4XBE8xc=; h=Subject:From:To:In-Reply-To:References:Date:From; b=U+UKKizXfguhkzZuVD1Z0SLcGOzV1qCekrIGcRBj1dITMwP2CCHb5OZivVH74YcMt Xix22LowCJVmku0zzEleR3D2E0ohmlg2mFZsY9hUmpTluKwVcBWHOIFveZP3zI+vYN iW4CmWEAb1mz6mDBm8ejOswnAZ4M8ZE2zACHfug6EOTf3/tzLOw1g94G7XyPDDa2wM 6rawfHmPwKR4qSwqnZhjFdkSw4E0Uz6uCas0sqZCn1GJsn5N3of5ybsZVBqPMpK8YB x9FWJJFAlUPEVH6APmRrT0ZiLkYQcaPLUWpoqLuUG8lQwLVvt/UIZ1IlnVWojWxm1i 1IeUOlnsI2Utw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 98619240177 for ; Thu, 15 Feb 2024 17:20:01 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 77C4F1601B9; Thu, 15 Feb 2024 17:20:01 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240213073426.47433-1-jdek@itanimul.li> References: <20240213073426.47433-1-jdek@itanimul.li> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 15 Feb 2024 17:20:01 +0100 Message-ID: <170801400146.21676.342407900059142688@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avdevice: deprecate opengl outdev X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting J. Dekker (2024-02-13 08:34:25) > Signed-off-by: J. Dekker > --- > > These devices are fundamentally broken and usecases should be switched > away from output devices in general. Discussion in the thread tended towards > deprecation rather than immediate removal to give time for users to figure out > the best alternatives for their usecase. > > libavdevice/opengl_enc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c > index b2ac6eb16a..0c81ccc1c4 100644 > --- a/libavdevice/opengl_enc.c > +++ b/libavdevice/opengl_enc.c > @@ -224,6 +224,8 @@ typedef struct OpenGLContext { > int picture_height; ///< Rendered height > int window_width; > int window_height; > + > + int warned; > } OpenGLContext; > > static const struct OpenGLFormatDesc { > @@ -1060,6 +1062,14 @@ static av_cold int opengl_write_header(AVFormatContext *h) > AVStream *st; > int ret; > > + if (!opengl->warned) { > + av_log(opengl, AV_LOG_WARNING, > + "The opengl output device is deprecated. For monitoring purposes in ffmpeg you can output to a file or use pipes and a video player.\n" Besides Marton's comment, this could also elaborate a little on why it is deprecated, e.g. "...due to being fundamentally incompatible with libavformat API". Also, could add a removal remind to version_major.h, similar to FF_CODEC_CRYSTAL_HD. Other than those, looks good to me. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".