From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 451E847657 for ; Thu, 15 Feb 2024 14:51:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B66468D241; Thu, 15 Feb 2024 16:51:20 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9019E68CD3F for ; Thu, 15 Feb 2024 16:51:13 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=AAzzzbeq; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 21218240DA9 for ; Thu, 15 Feb 2024 15:51:13 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 59TU7zS5cpq2 for ; Thu, 15 Feb 2024 15:51:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1708008667; bh=jd9/7C+tpYq6Eb48DbZ/HRwmmCRNwmR3KnfthcLFD4Q=; h=Subject:From:To:In-Reply-To:References:Date:From; b=AAzzzbeqvK8XM/WHbRkjOaLtirfNxr2FQr91nJ6PYkiLwVbq6u9QrqP9Imsla9Gmz axF8SX0iaxGxJ23lvrl/VyEtdfLYd+YruminJwSfcv5+YjXB1567dvgdxcWW5xJZfs Fx5F/1ggaj5solzqjir+BOTusIBjfGbmZ79IzM0bpsa5qXBQS2FDeMYT4o2qVD+MId s41rxIUhFIPTDigCJ+zWQN7udbxRSwrwGbB1W+lCUfJmR1AH6lvYWKz4295H0REPXP hg4e4hrS6M/MOCTdpentWhKPRpmL5eq6YhoT6j+Qw7pdQi9wqLyTAjFHaZSP3tg51P uhF+jLXDpO8Aw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A1E37240177 for ; Thu, 15 Feb 2024 15:51:07 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 8265D1601B9; Thu, 15 Feb 2024 15:51:01 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <791f9b20-d5a9-956e-a68a-15c116c6cd7d@passwd.hu> References: <20240212211537.18468-1-cus@passwd.hu> <20240212211537.18468-2-cus@passwd.hu> <68db378c-53a5-4288-a94e-627588d02baa@gmail.com> <791f9b20-d5a9-956e-a68a-15c116c6cd7d@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 15 Feb 2024 15:51:01 +0100 Message-ID: <170800866150.21676.6200254298482964372@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-02-13 21:27:34) > > > On Tue, 13 Feb 2024, James Almer wrote: > > > On 2/12/2024 6:15 PM, Marton Balint wrote: > >> Signed-off-by: Marton Balint > >> --- > >> libavutil/channel_layout.h | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > >> index b8bff6f365..db0c005e87 100644 > >> --- a/libavutil/channel_layout.h > >> +++ b/libavutil/channel_layout.h > >> @@ -146,6 +146,10 @@ enum AVChannelOrder { > >> * as defined in AmbiX format $ 2.1. > >> */ > >> AV_CHANNEL_ORDER_AMBISONIC, > >> + /** > >> + * Number of channel orders, not part of ABI/API > >> + */ > >> + AV_CHANNEL_ORDER_NB > >> }; > > > > Is it worth adding this to a public header just to limit a loop in a test? A > > loop that fwiw still depends on an array that needs to be updated with more > > names if you add new orders. > > Several other enums also have this. So API consistency can be considered > a more important factor. I'd be concerned that many callers don't undertand the implications of "not part of the ABI". Maybe we should rename all of them to FF_ prefix to make it more clear callers should not use these? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".