From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1B7349497 for ; Mon, 12 Feb 2024 09:16:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A6F8368D164; Mon, 12 Feb 2024 11:16:29 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F2E868D085 for ; Mon, 12 Feb 2024 11:16:22 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=DwJHogQo; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4A8CE240DA9; Mon, 12 Feb 2024 10:16:22 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 4JdawDwbfMRw; Mon, 12 Feb 2024 10:16:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1707729381; bh=tWW1qbEgvlSv7vgxkdi0ZWOoLnj5gfgufZH0Njbtq8s=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=DwJHogQoK32v3uMJMyq0pHSVNIzLYl52WZ6H8fJuLmXZk2FPY70iXkhaKXvIwtH1+ t7cSsSpqPIHAM4xWAufSHlPIIg3MoDGL4+/WFc0TeSZ5KMLI7zixmqIwpfOZ2h44yJ jRcIhTovlvkIfszkkwMiFihfRzB6cFD6xLc4294jF+JT+vMOrmpux4NNlG+tUw8gl3 1EqisdOd88XgyWPb1q0Q1301aC58z4pab9jB+tvcyMwXI/uZTOqComo4FiiwM8KESP NAK50DdJuu4YtYVJfWYcG914etP+HCSyssttb1K2ptmd8KVd+afBNeBeajc4r0SFtu H6cXwSlPNsZ8w== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B0071240177; Mon, 12 Feb 2024 10:16:21 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 87D4A1601B9; Mon, 12 Feb 2024 10:16:21 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Mon, 12 Feb 2024 10:16:21 +0100 Message-ID: <170772938152.8914.17691060997675528581@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avutil/opt: Fix AV_OPT_TYPE_CONST default value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2024-02-04 17:54:35) > It uses the int64_t instead of the double member. > > (This code can currently not be reached: av_opt_get() calls > av_opt_find2() with NULL as unit in which case AV_OPT_TYPE_CONST > options are never returned, leading av_opt_get() to always > return AVERROR_OPTION_NOT_FOUND when searching for AV_OPT_TYPE_CONST*. > For the same reason the code read_number() will never be called > from get_number() when searching for an option of type > AV_OPT_TYPE_CONST. The other callers of read_number() also only > call it with types other than AV_OPT_TYPE_CONST.) Is there a reason you're not disabling that code with an assert instead? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".