Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: Cosmin Stejerean <cosmin@cosmin.at>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.
Date: Sun, 04 Feb 2024 12:45:08 +0100
Message-ID: <170704710820.8914.3712453623456383005@lain.khirnov.net> (raw)
In-Reply-To: <0101018d73d5e244-ce817aaf-1e13-4688-8c1b-c55869a78372-000000@us-west-2.amazonses.com>

Quoting Cosmin Stejerean via ffmpeg-devel (2024-02-04 12:16:53)
> diff --git a/libavcodec/packet.h b/libavcodec/packet.h
> index 2c57d262c6..215b1c9970 100644
> --- a/libavcodec/packet.h
> +++ b/libavcodec/packet.h
> @@ -299,6 +299,13 @@ enum AVPacketSideDataType {
>       */
>      AV_PKT_DATA_DYNAMIC_HDR10_PLUS,
>  
> +    /**
> +     * Ambient viewing environment metadata, as defined by H.274.. This metadata
> +     * should be associated with a video stream and contains data in the form
> +     * of the AVAmbientViewingEnvironment struct.
> +    */
> +    AV_PKT_DATA_AMBIENT_VIEWING_ENVIRONMENT,

New entries must be added at the end, otherwise this breaks ABI.

It also needs a minor lavc bump and an APIchanges entry.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-02-04 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240204111648.76522-1-cosmin@cosmin.at>
2024-02-04 11:16 ` [FFmpeg-devel] [PATCH v3 0/3] avformat/mov: add support for 'amve' ambient viewing environment box Cosmin Stejerean via ffmpeg-devel
     [not found] ` <20240204111648.76522-2-cosmin@cosmin.at>
2024-02-04 11:16   ` [FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data Cosmin Stejerean via ffmpeg-devel
2024-02-04 11:45     ` Anton Khirnov [this message]
     [not found]       ` <57A56D7C-E692-4A97-93AC-8436B5B38739@cosmin.at>
2024-02-04 11:51         ` Cosmin Stejerean via ffmpeg-devel
     [not found] ` <20240204111648.76522-3-cosmin@cosmin.at>
2024-02-04 11:16   ` [FFmpeg-devel] [PATCH v3 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document Cosmin Stejerean via ffmpeg-devel
2024-02-04 12:28     ` James Almer
     [not found] ` <20240204111648.76522-4-cosmin@cosmin.at>
2024-02-04 11:16   ` [FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box Cosmin Stejerean via ffmpeg-devel
2024-02-04 12:45     ` James Almer
     [not found]       ` <C603FBA4-EA08-4952-A2D3-82C5EC5A1E04@cosmin.at>
2024-02-04 13:01         ` Cosmin Stejerean via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170704710820.8914.3712453623456383005@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=cosmin@cosmin.at \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git