From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A1DDC43DB9 for ; Sun, 4 Feb 2024 09:12:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF5CA68D14E; Sun, 4 Feb 2024 11:12:24 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7719868CA50 for ; Sun, 4 Feb 2024 11:12:18 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=EclpFtoC; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2B2D7240DA9 for ; Sun, 4 Feb 2024 10:12:18 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id J_j60E_WnJf3 for ; Sun, 4 Feb 2024 10:12:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1707037937; bh=SDDFXDmQkWl2VOpAYwyrdODsIkS98vL7AhKEmtu8Qu4=; h=Subject:From:To:In-Reply-To:References:Date:From; b=EclpFtoCwKtDtTVK95onvOzsMQj2RCci9NoYEK6Q7Wxg8aWbrF1RNQnyjW+eadXRb qOD6M8ny1vi3/JhO0IFLhQGHv63198cri4HMQEs1waJ9qCo33J80ZN+tZGlfpxCMyz EonzXJRmNA4WDtOAMnfFwzKJ+ZJAw6L2n6k1csODO+jkQ2Ct6wawD/hyKWDu7qZa1E GX6gAuYll9nOMRBMFqHkMjK1HZhTTBYJrIS+1mpFJMQty5FbPeP1dIbYBr5/Rjb3fq V1P8NwDfNGXsnW7GVAGpOi6jVhYC753gAqMsxxiHaT3biuTOyo1BHuBQM5nrpj/AC5 drbmv3s/Yko9A== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0B399240177 for ; Sun, 4 Feb 2024 10:12:17 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D7EB11601B9; Sun, 4 Feb 2024 10:12:16 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <033fea06-df8b-486d-9985-c53c26568aab@gmail.com> References: <033fea06-df8b-486d-9985-c53c26568aab@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 04 Feb 2024 10:12:16 +0100 Message-ID: <170703793685.8914.9379864965317424872@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix indentation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2024-02-04 08:20:55) > > If we're changing this block of code anyway, could we possibly replace > this line: > > if ((ret = ff_nut_add_sp(nut, nut->last_syncpoint_pos, 0 > /*unused*/, pkt->dts)) < 0) > goto fail; > > With something like this? > > ret = ff_nut_add_sp(nut, nut->last_syncpoint_pos, 0 /*unused*/, pkt->dts); > if (ret < 0) > goto fail; > > It's a bit cleaner. I much prefer not to mix whitespace and other changes, it breaks color-moved, ignore-all-space and similar. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".