From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix indentation
Date: Sun, 04 Feb 2024 10:12:16 +0100
Message-ID: <170703793685.8914.9379864965317424872@lain.khirnov.net> (raw)
In-Reply-To: <033fea06-df8b-486d-9985-c53c26568aab@gmail.com>
Quoting Leo Izen (2024-02-04 08:20:55)
>
> If we're changing this block of code anyway, could we possibly replace
> this line:
>
> if ((ret = ff_nut_add_sp(nut, nut->last_syncpoint_pos, 0
> /*unused*/, pkt->dts)) < 0)
> goto fail;
>
> With something like this?
>
> ret = ff_nut_add_sp(nut, nut->last_syncpoint_pos, 0 /*unused*/, pkt->dts);
> if (ret < 0)
> goto fail;
>
> It's a bit cleaner.
I much prefer not to mix whitespace and other changes, it breaks
color-moved, ignore-all-space and similar.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-04 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 19:20 Andreas Rheinhardt
2024-02-04 7:20 ` Leo Izen
2024-02-04 9:12 ` Anton Khirnov [this message]
2024-02-06 9:00 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170703793685.8914.9379864965317424872@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git