From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F0B464840A for ; Fri, 2 Feb 2024 04:42:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A0F868CA0D; Fri, 2 Feb 2024 06:42:18 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F370F68CA0D for ; Fri, 2 Feb 2024 06:42:11 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=PpBGvHdI; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 829F6240DA9 for ; Fri, 2 Feb 2024 05:42:11 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id AADU-tpeMXz0 for ; Fri, 2 Feb 2024 05:42:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706848930; bh=iMJ1TKMgYmycWwVPcieC0bC+ogk1Y1g9CX5af9sKUkM=; h=Subject:From:To:In-Reply-To:References:Date:From; b=PpBGvHdI93Rfff7IGvGTVgpAwr2UtmZVgHER0HXFO8CNMVULe9qZvONl+52cbeiTZ CrtAUMW7ACoE1UmRjXLUjndvsYxzS6DrrOu+3EO3dZBWuecbbiLcdawCc0cTgedfpn ZnTDnZvx9sYH+geU8MSGRtSli4KTsxTyBLbBgxDPueC980oTnXhn3TtuUcMEnPnTwo y6SburQsbtoC+hcOzDWNZ5/7ghyxYnJ2SMZ5afc1s99DNlVpSN/KpSDqn9/AIdjdTy DE/WfyLDPb99D1x4YYyEQtay3uFjok8HpQBj0Swb3L4hquRDWWqrEsg0c9O3Uu+ahm LihPeMYaGmlcw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id C79BC240177 for ; Fri, 2 Feb 2024 05:42:10 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id A62D61601B9; Fri, 2 Feb 2024 05:42:10 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240129232755.9622-1-cus@passwd.hu> <20240129232755.9622-3-cus@passwd.hu> <170677781445.8914.8380277934131001805@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 02 Feb 2024 05:42:10 +0100 Message-ID: <170684893065.19452.1318943911869359792@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/5] avutil/channel_layout: add av_channel_layout_from_custom() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-02-01 21:01:37) > > > On Thu, 1 Feb 2024, Anton Khirnov wrote: > > > Quoting Marton Balint (2024-01-30 00:27:53) > >> Signed-off-by: Marton Balint > >> --- > >> doc/APIchanges | 3 +++ > >> libavutil/channel_layout.c | 20 ++++++++++++++++++++ > >> libavutil/channel_layout.h | 13 +++++++++++++ > >> libavutil/version.h | 4 ++-- > >> 4 files changed, 38 insertions(+), 2 deletions(-) > >> > >> diff --git a/doc/APIchanges b/doc/APIchanges > >> index e477ed78e0..8e8498f803 100644 > >> --- a/doc/APIchanges > >> +++ b/doc/APIchanges > >> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09 > >> > >> API changes, most recent first: > >> > >> +2024-02-xx - xxxxxxxxxx - lavu 58.37.100 - channel_layout.h > >> + Add av_channel_layout_from_custom(). > > > > The name seems misleading to me, there is no 'custom' from which a > > channel layout is derived. > > > > It should be something like av_channel_layout_custom_init() instead. > > The other initializer functions follow the av_channel_layout_from_* > pattern. But I can rename of course if that is preferred. All av_foo_from_x() take x and build foo from it, but this function does not. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".