Re: [FFmpeg-devel] [PATCH 3/5] avutil/channel_layout: add av_channel_layout_from_custom()

[Anton Khirnov <anton@khirnov.net>]

Quoting Marton Balint (2024-02-01 21:01:37)
> 
> 
> On Thu, 1 Feb 2024, Anton Khirnov wrote:
> 
> > Quoting Marton Balint (2024-01-30 00:27:53)
> >> Signed-off-by: Marton Balint <cus@passwd.hu>
> >> ---
> >>  doc/APIchanges             |  3 +++
> >>  libavutil/channel_layout.c | 20 ++++++++++++++++++++
> >>  libavutil/channel_layout.h | 13 +++++++++++++
> >>  libavutil/version.h        |  4 ++--
> >>  4 files changed, 38 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/doc/APIchanges b/doc/APIchanges
> >> index e477ed78e0..8e8498f803 100644
> >> --- a/doc/APIchanges
> >> +++ b/doc/APIchanges
> >> @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09
> >>
> >>  API changes, most recent first:
> >>
> >> +2024-02-xx - xxxxxxxxxx - lavu 58.37.100 - channel_layout.h
> >> +  Add av_channel_layout_from_custom().
> >
> > The name seems misleading to me, there is no 'custom' from which a
> > channel layout is derived.
> >
> > It should be something like av_channel_layout_custom_init() instead.
> 
> The other initializer functions follow the av_channel_layout_from_* 
> pattern. But I can rename of course if that is preferred.

All av_foo_from_x() take x and build foo from it, but this function does
not.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".