From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5D1B848AEC for ; Thu, 1 Feb 2024 09:02:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE88968CF5C; Thu, 1 Feb 2024 11:02:11 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7033468CD88 for ; Thu, 1 Feb 2024 11:02:05 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=BZ6MiAtx; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 27458240DA9; Thu, 1 Feb 2024 10:02:05 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id rEtu6FJpTaB8; Thu, 1 Feb 2024 10:02:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706778124; bh=s63dbY7LerRTvoBhr0IKvTyKqs6LtX+BJHxPUa84avE=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=BZ6MiAtxXKeVuhnXBzqMPEaVO7VqsF2DXpIuROoef+1ExQZHnpjQuXHpMf+JzLYMq B56bPv9y7d43U+moUiaNFLocPWoVEbbIKbILQBEvA3PAGH9+4aX1ynOrv92oLACXDV 4rydb1tBpKBu50wISSOwbeJmxVV40lssVcoaYfJw2CWNbEiRoBnL3qJ5dWSbBpB91y 8ZUE0xSqVWHk7NFOEHHwKdILr6LbMLQz2TIc/p0nMrG6BlMy7dhMt1ypkTIkcdgunn yROofQEhoQX0odYo+k5fMZojq2NqSjDh83UP0ff3C2h4U2zpPbh29WNk2Aq2sfbYme EkBbhcNdD1W7g== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 77CE6240177; Thu, 1 Feb 2024 10:02:04 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 61B5A1601B9; Thu, 1 Feb 2024 10:02:04 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240131230136.30924-1-cus@passwd.hu> References: <20240129232755.9622-4-cus@passwd.hu> <20240131230136.30924-1-cus@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint Date: Thu, 01 Feb 2024 10:02:04 +0100 Message-ID: <170677812437.8914.7666506536395922524@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-02-01 00:01:36) > diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h > index 37629ab5d2..7e27a00d39 100644 > --- a/libavutil/channel_layout.h > +++ b/libavutil/channel_layout.h > @@ -817,6 +817,17 @@ int av_channel_layout_check(const AVChannelLayout *channel_layout); > */ > int av_channel_layout_compare(const AVChannelLayout *chl, const AVChannelLayout *chl1); > > +/** > + * Try changing the AVChannelOrder of a channel layout. What exactly is the rule for when the change succeeds or not? I would expect it to be when all the channels can be represented in the new order, but that is not the case for conversion to unspec. > + * > + * @param channel_layout channel layout which will be changed > + * @param order the desired channel layout order > + * @return 0 on success or if the channel layout is already in the desired order > + * 1 if using the desired order is not possible for the specified layout AVERROR(ENOSYS) seems more consistent to me -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".