Re: [FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype()

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marton Balint <cus@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype()
Date: Thu, 01 Feb 2024 10:02:04 +0100
Message-ID: <170677812437.8914.7666506536395922524@lain.khirnov.net> (raw)
In-Reply-To: <20240131230136.30924-1-cus@passwd.hu>

Quoting Marton Balint (2024-02-01 00:01:36)
> diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h
> index 37629ab5d2..7e27a00d39 100644
> --- a/libavutil/channel_layout.h
> +++ b/libavutil/channel_layout.h
> @@ -817,6 +817,17 @@ int av_channel_layout_check(const AVChannelLayout *channel_layout);
>   */
>  int av_channel_layout_compare(const AVChannelLayout *chl, const AVChannelLayout *chl1);
>  
> +/**
> + * Try changing the AVChannelOrder of a channel layout.

What exactly is the rule for when the change succeeds or not? I would
expect it to be when all the channels can be represented in the new
order, but that is not the case for conversion to unspec.

> + *
> + * @param channel_layout channel layout which will be changed
> + * @param order the desired channel layout order
> + * @return 0 on success or if the channel layout is already in the desired order
> + *         1 if using the desired order is not possible for the specified layout

AVERROR(ENOSYS) seems more consistent to me

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".