From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F0BEA48AE6 for ; Thu, 1 Feb 2024 08:57:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 74BF868CE3B; Thu, 1 Feb 2024 10:57:02 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90D6E68CBAD for ; Thu, 1 Feb 2024 10:56:56 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=SlMb3DHf; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 46C41240DA9; Thu, 1 Feb 2024 09:56:56 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id JR05OQPEkuK3; Thu, 1 Feb 2024 09:56:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706777815; bh=pjSDDj/af90utwHtP3DRDo0AB1hpzExea3dE4f+9K9Q=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=SlMb3DHf1dIa9bcuzLLg+LnXFkKxEgwt5jGjurOKT6ES9Dl9LCQgBVDFv7Gwz9rA1 BD8hj29tqBH92h4cBHuVA1Z5s08QKIgQpz40tbaeQlJlW1HZ74nka+W72qPNaYHX9N IbOEKjnnBQEo+Oi+twIyCkcCETZXAA/sdCxWVh25KEuR3+cZk2y3LKtxVbCWs+jrmH /ZGkYu7BN4W8fm5C4hCpVpN8+hyuUyNWRSEuWKQI+NnVFEzaITi5yOr+ktG3izr17c n7mMV89dp/ZsPzv9nqWQg/gxdyDkWKwUDe6HBnFw5kbxEGlyQRe11ZfL9Ajnsc51iT YSFMfJdMt3FnQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 86C57240177; Thu, 1 Feb 2024 09:56:55 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 746A41601B9; Thu, 1 Feb 2024 09:56:54 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240129232755.9622-3-cus@passwd.hu> References: <20240129232755.9622-1-cus@passwd.hu> <20240129232755.9622-3-cus@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches , Marton Balint Date: Thu, 01 Feb 2024 09:56:54 +0100 Message-ID: <170677781445.8914.8380277934131001805@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/5] avutil/channel_layout: add av_channel_layout_from_custom() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marton Balint Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2024-01-30 00:27:53) > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/channel_layout.c | 20 ++++++++++++++++++++ > libavutil/channel_layout.h | 13 +++++++++++++ > libavutil/version.h | 4 ++-- > 4 files changed, 38 insertions(+), 2 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index e477ed78e0..8e8498f803 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -2,6 +2,9 @@ The last version increases of all libraries were on 2023-02-09 > > API changes, most recent first: > > +2024-02-xx - xxxxxxxxxx - lavu 58.37.100 - channel_layout.h > + Add av_channel_layout_from_custom(). The name seems misleading to me, there is no 'custom' from which a channel layout is derived. It should be something like av_channel_layout_custom_init() instead. > +/** > + * Initialize a custom channel layout with the specified number of channels. > + * The designation of all channels will be unknown. > + * > + * @param channel_layout the layout structure to be initialized > + * @param nb_channels the number of channels > + * > + * @return 0 on success > + * AVERROR(EINVAL) if the number of channels <= 0 > + * AVERROR(ENOMEM) if the channel map could not be allocated > + */ It should say that this is a convenience helper, so people don't think this is the only way to build custom layouts. It should also explicitly say it allocates the channel map array. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".