From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C374448F4F for ; Tue, 30 Jan 2024 12:51:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5E82168D361; Tue, 30 Jan 2024 14:51:58 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 36A1768D34B for ; Tue, 30 Jan 2024 14:51:56 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=SJQmEeJE; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5BB0F2405F2 for ; Tue, 30 Jan 2024 13:51:56 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id yJnDU2sBr29s for ; Tue, 30 Jan 2024 13:51:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706619115; bh=4ubmT6MjohwD6V9BDKVCb7vEpQQQgrp9nlXCdFLND5Y=; h=Subject:From:To:In-Reply-To:References:Date:From; b=SJQmEeJER2I4E3DkhC46emrKNzNqEHup3QgAWsdXUzmnvXuIPzliprFM9S5toBTkR +6ZZ6L1IpMqZWXVwExdggCQtiF+Nihn3BXbvyCnSrqrMeE5YdGp+jWTF19IpXibDk+ R/8S7a+z5qNsVMV7OxDYOjZVb8nxtLFeOyomMQTGk1GLl1zhSbtZiOcRNPUDPUwC3Q HaoEc8bdIq6wqhl0TerSO5NDW7qVvoEkuGzSGW0Adnm7PR/XK5oEaxOaW5+R0BYQXn zJ9W8wZJVQ72W7LwEL8TmPs79ODcGXvNqjHnz0O8ZWtSuLj/wq9ghausMmKm8ES2Q+ Y/QtkOD+CBFqw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 94DAE2404E5 for ; Tue, 30 Jan 2024 13:51:55 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 812E31601B9; Tue, 30 Jan 2024 13:51:55 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240129184215.16685-1-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 30 Jan 2024 13:51:55 +0100 Message-ID: <170661911550.1197.2611997212025820879@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-01-30 13:39:19) > > + av_log(ctx, AV_LOG_INFO, > > + "n:%7"PRIu64" " > > + "size:%7d " > > + "pts:%s pt:%s " > > + "dts:%s dt:%s " > > + "ds:%"PRId64" d:%s " > > Why the trailing space? Copypasted from above mainly. But also it doesn't hurt and adding more entries won't require modifying this line. > > > + "\n", > > + priv->nb_packets, pkt->size, > > + av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in), > > + av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in), > > + pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in)); > > No av_ts2str for duration? Yes, duration cannot be AV_NOPTS_VALUE. > Also, missing side data. It's useful to know if a bitstream in the > chain/list added or removed any. > Maybe all the printing from lavf/dump.c can be shared somehow? Or just > duplicated. Exactly, side data makes this more complicated. I'd rather get the basic filter in, and then people can it as they see fit. Another thing I'm deliberately not printing yet is some sort of codec parameters summary. Patches welcome. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".