Re: [FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter

[Anton Khirnov <anton@khirnov.net>]

Quoting James Almer (2024-01-30 13:39:19)
> > +        av_log(ctx, AV_LOG_INFO,
> > +               "n:%7"PRIu64" "
> > +               "size:%7d "
> > +               "pts:%s pt:%s "
> > +               "dts:%s dt:%s "
> > +               "ds:%"PRId64" d:%s "
> 
> Why the trailing space?

Copypasted from above mainly. But also it doesn't hurt and adding more
entries won't require modifying this line.

> 
> > +               "\n",
> > +               priv->nb_packets, pkt->size,
> > +               av_ts2str(pkt->pts), av_ts2timestr(pkt->pts, &ctx->time_base_in),
> > +               av_ts2str(pkt->dts), av_ts2timestr(pkt->dts, &ctx->time_base_in),
> > +               pkt->duration, av_ts2timestr(pkt->duration, &ctx->time_base_in));
> 
> No av_ts2str for duration?

Yes, duration cannot be AV_NOPTS_VALUE.

> Also, missing side data. It's useful to know if a bitstream in the 
> chain/list added or removed any.
> Maybe all the printing from lavf/dump.c can be shared somehow? Or just 
> duplicated.

Exactly, side data makes this more complicated. I'd rather get the basic
filter in, and then people can it as they see fit. Another thing I'm
deliberately not printing yet is some sort of codec parameters summary.
Patches welcome.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".