From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/bsf: add a showinfo filter
Date: Tue, 30 Jan 2024 10:11:52 +0100
Message-ID: <170660591293.8914.13476664734959108442@lain.khirnov.net> (raw)
In-Reply-To: <AS8P250MB07441F8FA99039C5B0EDED5C8F7D2@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
Quoting Andreas Rheinhardt (2024-01-30 08:17:23)
> > +#include <stdint.h>
>
> You should use inttypes.h instead -- it provides everything stdint.h
> provides and the print directive defines like PRId64.
>
> > +static int showinfo_filter(AVBSFContext *ctx, AVPacket *pkt)
> > +{
> > + ShowinfoContext *priv = ctx->priv_data;
> > +
> > + while (1) {
>
> This loop will only ever be executed once and should be removed.
Right, both done locally.
Thanks,
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-01-30 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:42 Anton Khirnov
2024-01-30 7:17 ` Andreas Rheinhardt
2024-01-30 9:11 ` Anton Khirnov [this message]
2024-01-30 12:39 ` James Almer
2024-01-30 12:51 ` Anton Khirnov
2024-02-12 22:35 ` Alexander Strasser via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170660591293.8914.13476664734959108442@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git