From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E92F248D93 for ; Fri, 26 Jan 2024 16:24:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5850968D172; Fri, 26 Jan 2024 18:24:10 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BF04B68D140 for ; Fri, 26 Jan 2024 18:24:03 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=j+iQkjDR; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 8CB0A2405F2 for ; Fri, 26 Jan 2024 17:24:03 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id WXYH2eVKzNGL for ; Fri, 26 Jan 2024 17:24:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706286243; bh=HljOLJ0AaUEwboq9gAuISXySjCUJmSe1Jbz1VgEpDoc=; h=Subject:From:To:In-Reply-To:References:Date:From; b=j+iQkjDR0fnMjYMee1euZkv1V+vGIr9fRWm5Wp0dM+M7eUVwBG1gpwXZg19yKoE/a X6RIGyIIv5Quo5pORxvuZMUsDhxJr9s60upiDjkAJZLpsgelnqcw3i5yX1uLO0r164 FKMYlFppGDB8HgDQnGf3Te22Ym10AlgQk9qBFcvgJWJsJshz31m7awJz1qx5k3ouAj zm92nTMyZLW6JNQrOrG93TqNUDEX8cdN9hBedFfpgzlAPM68VPZF0IFPGuGSe+1ixy qqdFezYlQIU8U5IZtwvEqVdnl9HhJwqHxp/LMIo/tDPFN83g4cEcPT0+LRYIJK23uc JUWq/N5LgVOdg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1C8222404E5 for ; Fri, 26 Jan 2024 17:24:03 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0CAAD1601B9; Fri, 26 Jan 2024 17:24:03 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240126103905.17826-1-anton@khirnov.net> <170627145523.8914.14993136855646933607@lain.khirnov.net> <4f590e59-2a4b-4415-afb6-b1d54b4d5215@gmail.com> <170628585789.8914.11774088021293158816@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 26 Jan 2024 17:24:03 +0100 Message-ID: <170628624302.8914.16229409750840755180@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc: move bitstream filters into bsf/ subdir X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-01-26 17:22:06) > On 1/26/2024 1:17 PM, Anton Khirnov wrote: > > Quoting James Almer (2024-01-26 17:09:32) > >> On 1/26/2024 9:17 AM, Anton Khirnov wrote: > >>> Quoting Lynne (2024-01-26 13:11:33) > >>>> Jan 26, 2024, 11:40 by anton@khirnov.net: > >>>> > >>>>> --- > >>>>> libavcodec/Makefile | 49 +--------------- > >>>>> libavcodec/bsf/Makefile | 56 +++++++++++++++++++ > >>>>> > >>>> > >>>> Is that the general direction we want to take? > >>>> I don't mind it, but I'm wondering if I should do this for what I care about? > >>> > >>> I'd say yes for things with >~ 10 files. libavcodec/ got way too large. > >> > >> Is your idea something like.. > >> > >> libavcodec/bsf > >> libavcodec/common > >> libavcodec/decoder > >> libavcodec/encoder > >> libavcodec/parser > >> > >> And then subfolders within those for big modules like h264, hevc, vvc, > >> mpeg2, vp9, etc? > > > > No, that strikes me as overkill. A subdir for bsfs, a subdir for every > > codec/group of codecs/subsystem. > > I don't think it's overkill. It separates modules per type, so it's easy > to find a parser that right now is mixed between all the decoder related > files. My plan is for parsers to turn into bitstream filters, so... > >> And like Andreas mentioned, the arch subfolders need to be considered > >> for this. > > > > Why? > > I mean, where do you want them? inside the decoder/encoder subfolders > (thus splitting them), or outside as they are right now? I am perfectly fine with leaving them as they are now. Too many directory levels make things hard to find as well. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".