From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF09948D35 for ; Thu, 25 Jan 2024 10:04:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E302468D0C1; Thu, 25 Jan 2024 12:04:09 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1A95768CE20 for ; Thu, 25 Jan 2024 12:04:04 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Q+GFeOQH; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id CC8E52405F2; Thu, 25 Jan 2024 11:04:03 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id zDb0r3Afwe7D; Thu, 25 Jan 2024 11:04:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706177043; bh=X4aORn54TMpoqOIl+D7RKV1ajTzqhDwvLEyEfEaWqx8=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=Q+GFeOQHRViMUxNeW9DiNoOKpV9Q2ERB9X1PPhPARi/iwmo6spueGi4+N7Df+Ov2i EqM7KG9jfK2h8i2Nr+QXptlkdx0gdynvYX9ebJ+NznMKI+zcz+QmuDkgG/kzJjYjbe q/fPUWRkn4aaF++C1EymieIlODqvfkNRGwb7SVICYR8w+0CozTTke59/tmj1CM4WVm iO0KQ/Ai7AF233414Yypr1OmvIBFuNJzKDAjzUzp3CBUupwkEPk+uWO+a66/zOMQ96 JSE42axC6BIlqv/WPrk2OdNqGkkYMC2N7JBZFWqv9nF7SKvP5CHc36R4CAbLoPI/nI 5ukEbRyeD9Kbw== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 349152404E5; Thu, 25 Jan 2024 11:04:03 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2112F1601B9; Thu, 25 Jan 2024 11:04:03 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231231123018.59035-3-thilo.borgmann@mail.de> References: <20231231123018.59035-1-thilo.borgmann@mail.de> <20231231123018.59035-3-thilo.borgmann@mail.de> Mail-Followup-To: FFmpeg development discussions and patches , Thilo Borgmann Date: Thu, 25 Jan 2024 11:04:03 +0100 Message-ID: <170617704310.8914.705271194770221831@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14) > --- > libavcodec/webp.c | 50 +++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 44 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/webp.c b/libavcodec/webp.c > index 4fd107aa0c..58a20b73da 100644 > --- a/libavcodec/webp.c > +++ b/libavcodec/webp.c > @@ -194,6 +194,7 @@ typedef struct WebPContext { > AVFrame *alpha_frame; /* AVFrame for alpha data decompressed from VP8L */ > AVPacket *pkt; /* AVPacket to be passed to the underlying VP8 decoder */ > AVCodecContext *avctx; /* parent AVCodecContext */ > + AVCodecContext *avctx_vp8; /* wrapper context for VP8 decoder */ Nested codec contexts are in general highly undesirable and should be avoided whenever possible. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".