From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6712848CC6 for ; Wed, 24 Jan 2024 11:41:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6C06468D083; Wed, 24 Jan 2024 13:41:29 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1255168CB3A for ; Wed, 24 Jan 2024 13:41:23 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Xm1FQmzl; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D08782405F2 for ; Wed, 24 Jan 2024 12:41:22 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id QDEHROZkzKcH for ; Wed, 24 Jan 2024 12:41:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1706096482; bh=x+TsdrZZaLEmkUUN62oPUXZQ4Pd9CPUp6ZrQe5t5w88=; h=Subject:From:To:In-Reply-To:References:Date:From; b=Xm1FQmzlIifdz5aOZOUPdtHRohRTQA3Hj/GyZE3/J9ebItRRF9mGNbQfeRZ5HEUE6 mdezEWPju+tQ/ZXvP41JgoT9T24O6Xk57JgQd33zyk9339OwoVBnC5mw/z+m1F0DkC 0jkYAAG91gttQqiE8frXgxO5jtqXF7/JPfEdnnig1FRyMBChrTmhhrEEJT7MMCL3r5 PPGumzOEhQiW06OspzKOEs2MvSBL7mJhATJvlGr0f2UDjjGJ8dQBQHyFSQ7KRCFVW/ RR99ZiQ/EK1x+Mp9VEKHO3ymMRNKB3Fv54Pec9HaIGqooOePHnKLmBzxZjPAnJ4WIJ H60EOixaSAGUQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 53B252404E5 for ; Wed, 24 Jan 2024 12:41:22 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2F2C81601B9; Wed, 24 Jan 2024 12:41:22 +0100 (CET) From: Anton Khirnov To: "ffmpeg-devel@ffmpeg.org" In-Reply-To: References: Mail-Followup-To: "ffmpeg-devel@ffmpeg.org" Date: Wed, 24 Jan 2024 12:41:22 +0100 Message-ID: <170609648216.8914.11231022843595402569@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Use little endian in fixed() and improve the pos check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Dai, Jianhui J (2024-01-23 03:58:24) > This commit adds value range checks to cbs_vp8_read_unsigned_le, > migrates fixed() to use it, and enforces little-endian consistency for > all read methods. > > The VP8 compressed header may not be byte-aligned due to boolean coding. > Use bitwise comparison to prevent the potential overread. > > TETS: ffmpeg -i fate-suite/vp8-test-vectors-r1/* -vcodec copy -bsf:v > trace_headers -f null - > > Signed-off-by: Jianhui Dai > --- > libavcodec/cbs_vp8.c | 53 +++++++++++++++++++++++++++++++------------- > 1 file changed, 37 insertions(+), 16 deletions(-) This patch seems to contain many unrelated cosmetic changes. Those should be moved to a separate patch. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".