* [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
@ 2024-01-15 23:58 Stefano Sabatini
2024-01-20 11:41 ` Stefano Sabatini
2024-01-24 7:47 ` Anton Khirnov
0 siblings, 2 replies; 5+ messages in thread
From: Stefano Sabatini @ 2024-01-15 23:58 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Stefano Sabatini
---
fftools/opt_common.c | 28 +++++++++++++++++++++-------
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/fftools/opt_common.c b/fftools/opt_common.c
index f5b73c9f2f..e263a5297e 100644
--- a/fftools/opt_common.c
+++ b/fftools/opt_common.c
@@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
const char *last_name;
int is_dev;
- printf("%s\n"
- " D. = Demuxing supported\n"
- " .E = Muxing supported\n"
- " --\n", device_only ? "Devices:" : "File formats:");
+ if (device_only) {
+ printf("Devices:\n"
+ " D. = Demuxing supported\n"
+ " .E = Muxing supported\n"
+ " --\n");
+ } else {
+ printf("Formats:\n"
+ " D.. = Demuxing supported\n"
+ " .E. = Muxing supported\n"
+ " ..d = Is a device\n"
+ " ---\n");
+ }
last_name = "000";
for (;;) {
int decode = 0;
int encode = 0;
+ int device = 0;
const char *name = NULL;
const char *long_name = NULL;
@@ -875,6 +884,7 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
name = ofmt->name;
long_name = ofmt->long_name;
encode = 1;
+ device = is_dev;
}
}
}
@@ -889,20 +899,24 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
name = ifmt->name;
long_name = ifmt->long_name;
encode = 0;
+ device = is_dev;
}
- if (name && strcmp(ifmt->name, name) == 0)
+ if (name && strcmp(ifmt->name, name) == 0) {
decode = 1;
+ device = is_dev;
+ }
}
}
if (!name)
break;
last_name = name;
- printf(" %c%c %-15s %s\n",
+ printf(" %c%c%s %-15s %s\n",
decode ? 'D' : ' ',
encode ? 'E' : ' ',
+ device_only ? "" : (device ? "d" : " "),
name,
- long_name ? long_name:" ");
+ long_name ? long_name : " ");
}
return 0;
}
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
2024-01-15 23:58 [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device Stefano Sabatini
@ 2024-01-20 11:41 ` Stefano Sabatini
2024-01-23 22:59 ` Stefano Sabatini
2024-01-24 7:47 ` Anton Khirnov
1 sibling, 1 reply; 5+ messages in thread
From: Stefano Sabatini @ 2024-01-20 11:41 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On date Tuesday 2024-01-16 00:58:02 +0100, Stefano Sabatini wrote:
> ---
> fftools/opt_common.c | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index f5b73c9f2f..e263a5297e 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> const char *last_name;
> int is_dev;
>
> - printf("%s\n"
> - " D. = Demuxing supported\n"
> - " .E = Muxing supported\n"
> - " --\n", device_only ? "Devices:" : "File formats:");
> + if (device_only) {
> + printf("Devices:\n"
> + " D. = Demuxing supported\n"
> + " .E = Muxing supported\n"
> + " --\n");
> + } else {
> + printf("Formats:\n"
> + " D.. = Demuxing supported\n"
> + " .E. = Muxing supported\n"
> + " ..d = Is a device\n"
> + " ---\n");
> + }
> last_name = "000";
> for (;;) {
> int decode = 0;
> int encode = 0;
> + int device = 0;
> const char *name = NULL;
> const char *long_name = NULL;
>
> @@ -875,6 +884,7 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> name = ofmt->name;
> long_name = ofmt->long_name;
> encode = 1;
> + device = is_dev;
> }
> }
> }
> @@ -889,20 +899,24 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> name = ifmt->name;
> long_name = ifmt->long_name;
> encode = 0;
> + device = is_dev;
> }
> - if (name && strcmp(ifmt->name, name) == 0)
> + if (name && strcmp(ifmt->name, name) == 0) {
> decode = 1;
> + device = is_dev;
> + }
> }
> }
> if (!name)
> break;
> last_name = name;
>
> - printf(" %c%c %-15s %s\n",
> + printf(" %c%c%s %-15s %s\n",
> decode ? 'D' : ' ',
> encode ? 'E' : ' ',
> + device_only ? "" : (device ? "d" : " "),
> name,
> - long_name ? long_name:" ");
> + long_name ? long_name : " ");
> }
> return 0;
> }
Ping about this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
2024-01-20 11:41 ` Stefano Sabatini
@ 2024-01-23 22:59 ` Stefano Sabatini
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Sabatini @ 2024-01-23 22:59 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On date Saturday 2024-01-20 12:41:41 +0100, Stefano Sabatini wrote:
> On date Tuesday 2024-01-16 00:58:02 +0100, Stefano Sabatini wrote:
> > ---
> > fftools/opt_common.c | 28 +++++++++++++++++++++-------
> > 1 file changed, 21 insertions(+), 7 deletions(-)
Ping, will push in a few days if I see no comments.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
2024-01-15 23:58 [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device Stefano Sabatini
2024-01-20 11:41 ` Stefano Sabatini
@ 2024-01-24 7:47 ` Anton Khirnov
2024-01-28 22:28 ` Stefano Sabatini
1 sibling, 1 reply; 5+ messages in thread
From: Anton Khirnov @ 2024-01-24 7:47 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Stefano Sabatini
Quoting Stefano Sabatini (2024-01-16 00:58:02)
> ---
> fftools/opt_common.c | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index f5b73c9f2f..e263a5297e 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> const char *last_name;
> int is_dev;
>
> - printf("%s\n"
> - " D. = Demuxing supported\n"
> - " .E = Muxing supported\n"
> - " --\n", device_only ? "Devices:" : "File formats:");
> + if (device_only) {
> + printf("Devices:\n"
> + " D. = Demuxing supported\n"
> + " .E = Muxing supported\n"
> + " --\n");
> + } else {
> + printf("Formats:\n"
> + " D.. = Demuxing supported\n"
> + " .E. = Muxing supported\n"
> + " ..d = Is a device\n"
> + " ---\n");
I don't like this duplication.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
2024-01-24 7:47 ` Anton Khirnov
@ 2024-01-28 22:28 ` Stefano Sabatini
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Sabatini @ 2024-01-28 22:28 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On date Wednesday 2024-01-24 08:47:52 +0100, Anton Khirnov wrote:
> Quoting Stefano Sabatini (2024-01-16 00:58:02)
> > ---
> > fftools/opt_common.c | 28 +++++++++++++++++++++-------
> > 1 file changed, 21 insertions(+), 7 deletions(-)
> >
> > diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> > index f5b73c9f2f..e263a5297e 100644
> > --- a/fftools/opt_common.c
> > +++ b/fftools/opt_common.c
> > @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
> > const char *last_name;
> > int is_dev;
> >
> > - printf("%s\n"
> > - " D. = Demuxing supported\n"
> > - " .E = Muxing supported\n"
> > - " --\n", device_only ? "Devices:" : "File formats:");
> > + if (device_only) {
> > + printf("Devices:\n"
> > + " D. = Demuxing supported\n"
> > + " .E = Muxing supported\n"
> > + " --\n");
> > + } else {
> > + printf("Formats:\n"
> > + " D.. = Demuxing supported\n"
> > + " .E. = Muxing supported\n"
> > + " ..d = Is a device\n"
> > + " ---\n");
>
> I don't like this duplication.
will apply with the code re-factored
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-28 22:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-15 23:58 [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device Stefano Sabatini
2024-01-20 11:41 ` Stefano Sabatini
2024-01-23 22:59 ` Stefano Sabatini
2024-01-24 7:47 ` Anton Khirnov
2024-01-28 22:28 ` Stefano Sabatini
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git