Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Stefano Sabatini <stefasab@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device
Date: Wed, 24 Jan 2024 08:47:52 +0100
Message-ID: <170608247298.8914.6612893899316918963@lain.khirnov.net> (raw)
In-Reply-To: <20240115235802.525608-1-stefasab@gmail.com>

Quoting Stefano Sabatini (2024-01-16 00:58:02)
> ---
>  fftools/opt_common.c | 28 +++++++++++++++++++++-------
>  1 file changed, 21 insertions(+), 7 deletions(-)
> 
> diff --git a/fftools/opt_common.c b/fftools/opt_common.c
> index f5b73c9f2f..e263a5297e 100644
> --- a/fftools/opt_common.c
> +++ b/fftools/opt_common.c
> @@ -853,14 +853,23 @@ static int show_formats_devices(void *optctx, const char *opt, const char *arg,
>      const char *last_name;
>      int is_dev;
>  
> -    printf("%s\n"
> -           " D. = Demuxing supported\n"
> -           " .E = Muxing supported\n"
> -           " --\n", device_only ? "Devices:" : "File formats:");
> +    if (device_only) {
> +        printf("Devices:\n"
> +               " D. = Demuxing supported\n"
> +               " .E = Muxing supported\n"
> +               " --\n");
> +    } else {
> +        printf("Formats:\n"
> +               " D.. = Demuxing supported\n"
> +               " .E. = Muxing supported\n"
> +               " ..d = Is a device\n"
> +               " ---\n");

I don't like this duplication.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".