From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EBE2945F91 for ; Wed, 17 Jan 2024 12:32:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F270468CF0F; Wed, 17 Jan 2024 14:32:45 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E485568BC30 for ; Wed, 17 Jan 2024 14:32:38 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=UID7aXpI; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9503F240DA9 for ; Wed, 17 Jan 2024 13:32:38 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id gzCnaWIEIZxw for ; Wed, 17 Jan 2024 13:32:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1705494758; bh=+kwOsa3JYZlpWOWirQXwofp4gf3D2sOnxiEmKwViHSI=; h=Subject:From:To:In-Reply-To:References:Date:From; b=UID7aXpIwqMvtQ4tSM4tUNy3nGnmkTLYXlU6ifv8zPoqwHvn+VHNyyAo+vn/t7RWo Ba6mfzC1UItaDqZCKN4qbRMjSRq7AHH/Tfxv+Pl+Zgja1EuHKUvg+D3iGa/ObjtW9g WjXueqUeajaXexD0GcB3wIPar9hArUHFUzJj9B/Nr084caw2OddsZpL5s9vyVc6cIk FwmM7FYMYvKkmBhXCieYsMxoV0Jko6frMZ2EcFxYoEBggWWCYKvMKTx8RAuk1L6AEb RT457kLgBHeabFhXySJhbBC+tCQ6sI4kByVvBU8UfZDjRJFiviSCbOlzR7jSOOk5mG r9P1UFLLFVJTA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1769D240DA8 for ; Wed, 17 Jan 2024 13:32:38 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 08E4F1601B9; Wed, 17 Jan 2024 13:32:31 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240117092233.8503-1-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 17 Jan 2024 13:32:31 +0100 Message-ID: <170549475100.8914.15631277342984118579@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/6] fftools/ffprobe: make option strings dynamically allocated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Zhao Zhili (2024-01-17 12:22:10) > > > > On Jan 17, 2024, at 17:22, Anton Khirnov wrote: > > > > Do not store the supplied arg pointer directly. While that is valid for > > now, arg will become ephemeral in the future commits. > > --- > > fftools/ffprobe.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > > index f00ba48620..3a7aae3572 100644 > > --- a/fftools/ffprobe.c > > +++ b/fftools/ffprobe.c > > @@ -3827,8 +3827,10 @@ static int opt_input_file(void *optctx, const char *arg) > > return AVERROR(EINVAL); > > } > > if (!strcmp(arg, "-")) > > - arg = "fd:"; > > - input_filename = arg; > > + arg = "pipe:"; > > Does the change of protocol on purpose, and why? Good catch, it was a rebase fail. Fixed locally. Thanks, -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".