Re: [FFmpeg-devel] [PATCH 1/6] fftools/ffprobe: make option strings dynamically allocated

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/6] fftools/ffprobe: make option strings dynamically allocated
Date: Wed, 17 Jan 2024 13:32:31 +0100
Message-ID: <170549475100.8914.15631277342984118579@lain.khirnov.net> (raw)
In-Reply-To: <tencent_A33E6757E99D72E0E85AF435B7800A351309@qq.com>

Quoting Zhao Zhili (2024-01-17 12:22:10)
> 
> 
> > On Jan 17, 2024, at 17:22, Anton Khirnov <anton@khirnov.net> wrote:
> > 
> > Do not store the supplied arg pointer directly. While that is valid for
> > now, arg will become ephemeral in the future commits.
> > ---
> > fftools/ffprobe.c | 18 +++++++++++++-----
> > 1 file changed, 13 insertions(+), 5 deletions(-)
> > 
> > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> > index f00ba48620..3a7aae3572 100644
> > --- a/fftools/ffprobe.c
> > +++ b/fftools/ffprobe.c
> > @@ -3827,8 +3827,10 @@ static int opt_input_file(void *optctx, const char *arg)
> >         return AVERROR(EINVAL);
> >     }
> >     if (!strcmp(arg, "-"))
> > -        arg = "fd:";
> > -    input_filename = arg;
> > +        arg = "pipe:";
> 
> Does the change of protocol on purpose, and why?

Good catch, it was a rebase fail.

Fixed locally.

Thanks,
-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".