From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B33D648732 for ; Tue, 16 Jan 2024 19:52:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C147968D06B; Tue, 16 Jan 2024 21:52:30 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C67468C426 for ; Tue, 16 Jan 2024 21:52:24 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=LiDS/rex; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 516F1240DA9 for ; Tue, 16 Jan 2024 20:52:24 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id oWQNMHnmG4VX for ; Tue, 16 Jan 2024 20:52:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1705434743; bh=ZfxRnroiymne2E1C4HORGIyUKllpEnN9tUMTKIae4qo=; h=Subject:From:To:In-Reply-To:References:Date:From; b=LiDS/rexxdANmDsjbViZhuNhCQ2N27fjjZGRtXREejUIEB/ycLtHUcmGes7OcqcmU r4DcWuij31qK2RTYAlxfsdUeGpnCW3nSxVlhtW4k/5MGqa+WrZkg7SniR0I6vrVj4R wwSwIJJmILTXDWJ3QQSAP/Lo139GyAuGUvab8+ygXyXa+x/xEwxWDUJ+5pOMS3TrwT gJ6O0BDVxldZ8ep7oWhga9C2CCeVNVYa7BAnmvRKhIZ0qKvd57ozHx9zCnd8q2+/nK luYZPjm6Bh9t8vcplWONk6nB5j15m7bGf5B9HLHuWvLgw4fhnLsUfr6SgIq2MFHzx8 8tQdVlR/jbBCg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A5DA6240DA8 for ; Tue, 16 Jan 2024 20:52:23 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 82DF31601B9; Tue, 16 Jan 2024 20:52:23 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240105164251.28935-1-anton@khirnov.net> <20240105164251.28935-6-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 16 Jan 2024 20:52:23 +0100 Message-ID: <170543474350.8914.14744052578299827400@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/8] fftools/ffmpeg_demux: add demuxing thread private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2024-01-06 12:44:27) > On date Friday 2024-01-05 17:42:49 +0100, Anton Khirnov wrote: > > To be used for data that never needs to be visible outside of the > > demuxer thread, similarly as was previously done for other components. > > --- > > fftools/ffmpeg_demux.c | 67 ++++++++++++++++++++++++++++-------------- > > 1 file changed, 45 insertions(+), 22 deletions(-) > > > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > > index c51140b1c5..eae1f0bde5 100644 > > --- a/fftools/ffmpeg_demux.c > > +++ b/fftools/ffmpeg_demux.c > > @@ -115,6 +115,11 @@ typedef struct Demuxer { > > int nb_streams_finished; > > } Demuxer; > > > > > +typedef struct DemuxThreadContext { > > + // packet used for reading from the demuxer > > > + AVPacket *pkt_demux; > > nit: you might drop the _demux suffix since this is already clear from > the context and it's adding no information I'm adding the suffix because a following commit adds another packet to the struct, so I prefer to make it clear what each one's role is. > > static void *input_thread(void *arg) > > { > > Demuxer *d = arg; > > InputFile *f = &d->f; > > - AVPacket *pkt; > > + > > + DemuxThreadContext dt; > > + > > nit++: weird style, you might drop the empty lines around the > declaration I prefer it this way. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".