From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F25C048703 for ; Tue, 16 Jan 2024 19:50:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7801368D068; Tue, 16 Jan 2024 21:50:37 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D96C568CFC8 for ; Tue, 16 Jan 2024 21:50:30 +0200 (EET) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=MMIMgYqL; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A51C9240DA9 for ; Tue, 16 Jan 2024 20:50:30 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id g0E104_TnTR2 for ; Tue, 16 Jan 2024 20:50:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1705434630; bh=FrXYV/YTcYbo3DM6XZhz/+Cq58cLtLLHVwoWLdW0W+k=; h=Subject:From:To:In-Reply-To:References:Date:From; b=MMIMgYqLfOjbpmUaa+EzjMSWj5h5ojWnu0l93AYRSmuz7NqzU4uP+g/G6N5hVn3Pp NZdWGl2m044XGcZIvB9KAEDqFfTsU6IwnZEs9wlIvnPpqXG5Yxetu67T08NuhUuVcm 7XylZwo1MSm5yvnKZvNRoz0DT3iHSNnvvvIur9PPXchHYhr85funocYtzQCMIxxHpV DaESi8DqX/g9ad31qCnfLjxCmT7n+5B9zRJFNPw2IZU3y/rbxfq0bQ6wzohVMyTM0m I+swUsaI1haqJYcwdl2NzjdTQ55hFAUw2+8Ep9pwWhJqHjv0MhOQtWZpBKO1Rqvwa9 5ogcJoPCYm4Dg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 13DE7240DA8 for ; Tue, 16 Jan 2024 20:50:30 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 04B711601B9; Tue, 16 Jan 2024 20:50:30 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20240105164251.28935-1-anton@khirnov.net> <20240105164251.28935-5-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 16 Jan 2024 20:50:29 +0100 Message-ID: <170543462999.8914.1999259557274599268@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/8] fftools/ffmpeg_demux: only allocate the decoder when actually decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2024-01-06 12:34:53) > On date Friday 2024-01-05 17:42:48 +0100, Anton Khirnov wrote: > > It is not needed otherwise. > > --- > > fftools/ffmpeg_demux.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > > index 892094c512..c51140b1c5 100644 > > --- a/fftools/ffmpeg_demux.c > > +++ b/fftools/ffmpeg_demux.c > > @@ -782,6 +782,16 @@ static int ist_use(InputStream *ist, int decoding_needed) > > if (decoding_needed && ds->sch_idx_dec < 0) { > > int is_audio = ist->st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO; > > > > + ist->dec_ctx = avcodec_alloc_context3(ist->dec); > > + if (!ist->dec_ctx) > > + return AVERROR(ENOMEM); > > + > > + ret = avcodec_parameters_to_context(ist->dec_ctx, ist->par); > > + if (ret < 0) { > > > + av_log(ist, AV_LOG_ERROR, "Error initializing the decoder context.\n"); > > unrelated, here and below: might be useful to notify the failing > stream identifier, assuming it is not already shown in the log It is, logging to ist prints something like [aist#0:0/pcm_s16le @ 0x563a40304b40] .... -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".