From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D95F488CE for ; Wed, 20 Dec 2023 09:51:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3923B68D202; Wed, 20 Dec 2023 11:51:11 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F369368BF73 for ; Wed, 20 Dec 2023 11:51:04 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C16A52405ED for ; Wed, 20 Dec 2023 10:51:04 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id jlA_KMWVHzxW for ; Wed, 20 Dec 2023 10:51:04 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 65D982400AC for ; Wed, 20 Dec 2023 10:51:04 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 56D9A1601B9; Wed, 20 Dec 2023 10:51:04 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 20 Dec 2023 10:51:04 +0100 Message-ID: <170306586433.8914.16398386237744409368@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting flow gg (2023-12-20 09:39:57) > > > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 > From: sunyuechi > Date: Wed, 20 Dec 2023 16:17:32 +0800 > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init typo in 'lavc' > > This is for clarity and use in testing, consistent with other parts of the code. > --- > libavcodec/dnxhdenc.c | 6 ++++++ > libavcodec/dnxhdenc.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c > index f52a2e9918..1ac8116f53 100644 > --- a/libavcodec/dnxhdenc.c > +++ b/libavcodec/dnxhdenc.c > @@ -1377,3 +1377,9 @@ const FFCodec ff_dnxhd_encoder = { > .p.profiles = NULL_IF_CONFIG_SMALL(ff_dnxhd_profiles), > .caps_internal = FF_CODEC_CAP_INIT_CLEANUP, > }; > + > +void ff_dnxhdenc_init(DNXHDEncContext *ctx) { Brace should be on its own line > +#if ARCH_X86 > + ff_dnxhdenc_init_x86(ctx); > +#endif > +} > diff --git a/libavcodec/dnxhdenc.h b/libavcodec/dnxhdenc.h > index e581312ce4..95aea83d28 100644 > --- a/libavcodec/dnxhdenc.h > +++ b/libavcodec/dnxhdenc.h > @@ -111,6 +111,7 @@ typedef struct DNXHDEncContext { > const uint8_t *pixels, ptrdiff_t line_size); > } DNXHDEncContext; > > +void ff_dnxhdenc_init(DNXHDEncContext *ctx); Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call in dnxhdenc.c? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".