From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F1983488A3 for ; Tue, 19 Dec 2023 12:11:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1892668D0B0; Tue, 19 Dec 2023 14:11:02 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1864A68D058 for ; Tue, 19 Dec 2023 14:10:55 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D38612405ED for ; Tue, 19 Dec 2023 13:10:54 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id fKm1ZUWd0QgD for ; Tue, 19 Dec 2023 13:10:54 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1B6A42400AC for ; Tue, 19 Dec 2023 13:10:54 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id E88201601B9; Tue, 19 Dec 2023 13:10:53 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <52289c00-e190-45e9-92bc-028459cd6f9d@gmail.com> References: <20231218191913.2071-1-anton@khirnov.net> <170298247031.8914.4423993700905646592@lain.khirnov.net> <52289c00-e190-45e9-92bc-028459cd6f9d@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 19 Dec 2023 13:10:53 +0100 Message-ID: <170298785392.8914.2659869163650906462@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf: allow setting AVStream.discard as an AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-12-19 13:09:05) > On 12/19/2023 7:41 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-12-18 20:30:47) > >> On 12/18/2023 4:19 PM, Anton Khirnov wrote: > >>> --- > >>> libavformat/options.c | 10 ++++++++++ > >>> 1 file changed, 10 insertions(+) > >>> > >>> diff --git a/libavformat/options.c b/libavformat/options.c > >>> index bf6113ca95..cc89dd6c72 100644 > >>> --- a/libavformat/options.c > >>> +++ b/libavformat/options.c > >>> @@ -229,6 +229,16 @@ static const AVOption stream_options[] = { > >>> { "metadata", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_METADATA }, .unit = "disposition" }, > >>> { "dependent", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_DEPENDENT }, .unit = "disposition" }, > >>> { "still_image", .type = AV_OPT_TYPE_CONST, { .i64 = AV_DISPOSITION_STILL_IMAGE }, .unit = "disposition" }, > >>> + > >>> + { "discard", NULL, offsetof(AVStream, discard), AV_OPT_TYPE_INT, { .i64 = AVDISCARD_DEFAULT }, INT_MIN, INT_MAX, > >>> + .flags = AV_OPT_FLAG_DECODING_PARAM, .unit = "avdiscard" }, > >>> + { "none", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONE }, .unit = "avdiscard" }, > >>> + { "default", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_DEFAULT }, .unit = "avdiscard" }, > >>> + { "noref", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONREF }, .unit = "avdiscard" }, > >>> + { "bidir", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_BIDIR }, .unit = "avdiscard" }, > >>> + { "nointra", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONINTRA }, .unit = "avdiscard" }, > >>> + { "nokey", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_NONKEY }, .unit = "avdiscard" }, > >>> + { "all", .type = AV_OPT_TYPE_CONST, {.i64 = AVDISCARD_ALL }, .unit = "avdiscard" }, > >>> { NULL } > >>> }; > >> > >> Should be ok. > >> > >> Maybe also add "id" like i did for AVStreamGroup while at it. > > > > The problem with id is how to flag it - it's read-only for demuxing and > > user-settable for muxing. > > Wouldn't the AV_OPT_FLAG_ENCODING_PARAM flag be enough for the CLI to > reject it for demuxing cases? Those flags should be set for all callers, not just the CLI. And for demuxing the proper flag is AV_OPT_FLAG_EXPORT -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".