From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3550D48844 for ; Mon, 18 Dec 2023 17:05:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D971768CEF0; Mon, 18 Dec 2023 19:05:50 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5656368CD2D for ; Mon, 18 Dec 2023 19:05:44 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 1FC452405ED for ; Mon, 18 Dec 2023 18:05:44 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Qa5uzqy-IH-Q for ; Mon, 18 Dec 2023 18:05:43 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 98E5E2400AC for ; Mon, 18 Dec 2023 18:05:43 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 744201601B9; Mon, 18 Dec 2023 18:05:43 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <2a220627-10e4-4807-950b-03b08331c926@gmail.com> References: <20231208173106.165084-1-leo.izen@gmail.com> <170254251501.8914.17063422483267428315@lain.khirnov.net> <2a220627-10e4-4807-950b-03b08331c926@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 18 Dec 2023 18:05:43 +0100 Message-ID: <170291914345.8914.13241698053564698030@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libjxldec: emit proper PTS to decoded AVFrame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2023-12-15 00:33:33) > On 12/14/23 03:28, Anton Khirnov wrote: > > This logic seems shady to me. > > Which part, specifically? The animated logic, or the non-animated logic? Aspects of both looked questionable to me (which doesn't necessarily means it's wrong) > > The decoder should mess with pts as little > > as possible and whenever it can just copy the packet value to the frame. > > Any codec-level timestamps should not be trusted. > > In the case of animated JXL, codec-level timestamps are all that's > available because the only demuxer is jpegxl_anim, which doesn't > packetize the individual frames. That may change in the future. And you shouldn't assume the caller is necessarily using lavf for demuxing, if you can help it. > > > > Now this does not work when a single packet decodes into multiple > > frames, then you have to add increments of frame duration to the > > original packet pts. But you should still preserve the original value as > > the base - it might not start at 0. > > I see what you're saying, but in the case where one packet decodes into > multiple frames in the non-animated stream, we don't have any way to > properly differentiate the PTS of those frames. When does that happen? And sure, I accept that when there's no other option you might have to take some liberties. I'm just saying it should be done as little as possible. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".