From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 65EE248805 for ; Mon, 18 Dec 2023 11:05:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CC8168D1D8; Mon, 18 Dec 2023 13:04:59 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 80B3A68D0B5 for ; Mon, 18 Dec 2023 13:04:53 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 154762405ED for ; Mon, 18 Dec 2023 12:04:53 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id l5pfStIxGsd2 for ; Mon, 18 Dec 2023 12:04:52 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id AC6DB2400AC for ; Mon, 18 Dec 2023 12:04:52 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 998C91601B9; Mon, 18 Dec 2023 12:04:52 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231214201433.4608-2-jamrial@gmail.com> References: <20231214201433.4608-1-jamrial@gmail.com> <20231214201433.4608-2-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 18 Dec 2023 12:04:52 +0100 Message-ID: <170289749260.8914.14905207691567469566@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/8] avutil: introduce an Immersive Audio Model and Formats API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-12-14 21:14:26) > +/** > + * Mix Gain Parameter Data as defined in section 3.8.1 of IAMF. > + */ > +typedef struct AVIAMFMixGain { > + const AVClass *av_class; > + > + /** > + * Duration for the given subblock. It must not be 0. In what units? Same for all durations in this patch. > +typedef struct AVIAMFParamDefinition { > + const AVClass *av_class; > + > + /** > + * Offset in bytes from the start of this struct, at which the subblocks > + * array is located. > + */ > + size_t subblocks_offset; > + /** > + * Size in bytes of each element in the subblocks array. > + */ > + size_t subblock_size; > + /** > + * Number of subblocks in the array. > + * > + * Must be 0 if @ref constant_subblock_duration is not 0. > + */ > + unsigned int nb_subblocks; > + > + /** > + * Parameters type. Determines the type of the subblock elements. > + */ > + enum AVIAMFParamDefinitionType type; > + > + /** > + * Identifier for the paremeter substream. > + */ > + unsigned int parameter_id; > + /** > + * Sample rate for the paremeter substream. It must not be 0. > + */ > + unsigned int parameter_rate; > + > + /** > + * The duration of the all subblocks in this parameter definition. > + * > + * May be 0, in which case all duration values should be specified in > + * another parameter definition referencing the same parameter_id. > + */ > + unsigned int duration; > + /** > + * The duration of every subblock in the case where all subblocks, with > + * the optional exception of the last subblock, have equal durations. > + * > + * Must be 0 if subblocks have different durations. > + */ > + unsigned int constant_subblock_duration; This also seems like should be a flags field. Otherwise looks good. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".