From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 272104761C for ; Thu, 14 Dec 2023 17:51:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 38E5E68D22A; Thu, 14 Dec 2023 19:51:37 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D1B0268D15B for ; Thu, 14 Dec 2023 19:51:30 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id BA0462405ED; Thu, 14 Dec 2023 18:51:29 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 2QOnr6GteeQF; Thu, 14 Dec 2023 18:51:25 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 96BE32400AC; Thu, 14 Dec 2023 18:51:25 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 74BC11601B9; Thu, 14 Dec 2023 18:51:19 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <9c0f12c9-5131-4f92-aff9-d48f5020bdec@mail.de> References: <20231211150725.46473-1-thilo.borgmann@mail.de> <20231211150725.46473-3-thilo.borgmann@mail.de> <170246885429.8914.10051704276943894799@lain.khirnov.net> <170246928230.8914.12754643765966025844@lain.khirnov.net> <170247117981.8914.16828787197695281420@lain.khirnov.net> <170248489636.8914.14641721027481345642@lain.khirnov.net> <170253142724.8914.2591211066924714059@lain.khirnov.net> <9c0f12c9-5131-4f92-aff9-d48f5020bdec@mail.de> Mail-Followup-To: FFmpeg development discussions and patches , Thilo Borgmann Date: Thu, 14 Dec 2023 18:51:19 +0100 Message-ID: <170257627944.8914.2969565919416524493@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffmpeg: move parsing of -stats_* specifiers to lavu/parseutils X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Thilo Borgmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-14 11:34:11) > Am 14.12.23 um 06:23 schrieb Anton Khirnov: > > Quoting Thilo Borgmann via ffmpeg-devel (2023-12-13 19:17:04) > >> Am 13.12.23 um 17:28 schrieb Anton Khirnov: > >>> It is bad practice to design library features around the needs and > >>> limitations of a single specific caller. > >> > >> The callers here would be the CLI and this filter. > > > > First, public APIs should be designed for general classes of use cases, > > not specific callers. > > Parsing a "...{var0}...{varN}..." string for its variables appears quite generic to me. > IMO, especially for libavutil, you think a bit too ideological here. You're not parsing generic variables though, but a predefined list of highly specific ones. > A) How about putting it under avpriv_ then? 1) fftools are not allowed to use avpriv functions. 2) It does not solve any of the problems I pointed out. > B) Not filibustering https://en.wiktionary.org/wiki/filibuster 2. (US politics) A tactic (such as giving long, often irrelevant speeches) employed to delay the proceedings of, or the making of a decision by, a legislative body, Are you seriously calling my comments irrelevant stalling? > about lib design, nor contradictory support of > this patch, but use a fixed format. IMHO just sad > for the user This is an appeal to emotion along the lines of "THINK OF THE CHILDREN". It is a fallacious argument that has no place in a technical discussion. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".