From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ADD69486B9 for ; Thu, 14 Dec 2023 08:03:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EE3C68D1F9; Thu, 14 Dec 2023 10:03:41 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DB95968D05A for ; Thu, 14 Dec 2023 10:03:34 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9F8CA2405ED for ; Thu, 14 Dec 2023 09:03:34 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id ngBv_eYghr0N for ; Thu, 14 Dec 2023 09:03:34 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0C19D2400AC for ; Thu, 14 Dec 2023 09:03:34 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id E93F61601B9; Thu, 14 Dec 2023 09:03:33 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20231206082220.5532-1-cus@passwd.hu> <20231206082220.5532-7-cus@passwd.hu> <170196664712.8914.15749136255711961223@lain.khirnov.net> <85f4ba43-ab24-2598-6346-28dfef2ee88e@passwd.hu> <170238021813.8914.858553900721142755@lain.khirnov.net> <11543aff-ca4-8427-318e-44ea5f41d65e@passwd.hu> <170245799658.8914.15010850707925643403@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 14 Dec 2023 09:03:33 +0100 Message-ID: <170254101392.8914.13689080332799681220@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2023-12-13 18:09:45) > On Wed, 13 Dec 2023, Anton Khirnov wrote: > > Quoting Marton Balint (2023-12-12 19:37:57) > >> > >> So for this flag, I'd rather make it clear it is not security-related, and > >> also that it has performance impact. > > > > So then maybe make a FF_EC flag? > > I thought about using that, but there are plenty of error concealment > code which only checks if avctx->error_concealment is nonzero or zero, and > not specific EC flags. So unless that is fixed (which might break existing > behaviour) one cannot introduce a new EC flag and disable error > concealment at the same time... If you don't feel like fixing all the places that do such checks, you could instead * add a flag in DecodeContext * in ff_decode_preinit(), map your new FF_EC_PREDECODE_CLEAR to the internal flag * clear FF_EC_PREDECODE_CLEAR in AVCodecContext That should avoid breaking any existing behavior. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".