From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6D222481EE for ; Wed, 13 Dec 2023 08:48:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 277BC68D067; Wed, 13 Dec 2023 10:48:47 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6F7E68D000 for ; Wed, 13 Dec 2023 10:48:39 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 196D72405ED; Wed, 13 Dec 2023 09:48:39 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Z_y0BQCg2lSn; Wed, 13 Dec 2023 09:48:38 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 687482400AC; Wed, 13 Dec 2023 09:48:38 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3F8A71601B9; Wed, 13 Dec 2023 09:48:38 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231109122534.124157-15-ffmpeg@haasn.xyz> References: <20231109122534.124157-1-ffmpeg@haasn.xyz> <20231109122534.124157-15-ffmpeg@haasn.xyz> Mail-Followup-To: FFmpeg development discussions and patches , Niklas Haas Date: Wed, 13 Dec 2023 09:48:38 +0100 Message-ID: <170245731823.8914.16801839805128195881@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 14/25] avfilter/vf_format: re-use AVFilterList for pix_fmt parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Niklas Haas (2023-11-09 13:19:46) >Subject: avfilter/vf_format: re-use AVFilterList for pix_fmt parsing ^^^^^^^^^^^^ You mean AVFilterFormats > From: Niklas Haas > > Rewrite the format parsing code to make it more easily generalizable. In > particular, `invert_formats` does not depend on the type of format list > passed to it, which allows me to re-use this helper in an upcoming > commit. > > Slightly shortens the code, at the sole cost of doing several malloc > (ff_add_format) instead of a single malloc. > --- > libavfilter/vf_format.c | 103 +++++++++++++++++----------------------- > 1 file changed, 43 insertions(+), 60 deletions(-) > > diff --git a/libavfilter/vf_format.c b/libavfilter/vf_format.c > index 1189bd61c2..b137e3075e 100644 > --- a/libavfilter/vf_format.c > +++ b/libavfilter/vf_format.c > @@ -41,25 +41,48 @@ typedef struct FormatContext { > const AVClass *class; > char *pix_fmts; > > - /** > - * pix_fmts parsed into AVPixelFormats and terminated with > - * AV_PIX_FMT_NONE > - */ > - enum AVPixelFormat *formats; > + AVFilterFormats *formats; ///< parsed from `pix_fmts` > } FormatContext; > > static av_cold void uninit(AVFilterContext *ctx) > { > FormatContext *s = ctx->priv; > - av_freep(&s->formats); > + ff_formats_unref(&s->formats); > +} > + > +static av_cold int invert_formats(AVFilterFormats **fmts, > + AVFilterFormats *allfmts) This would look better with AVFilterFormats vertically aligned as well. Looks ok otherwise, though I'm slightly surprised we don't seem to have a function for "is format in list?". -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".