From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/8] avformat: introduce AVStreamGroup
Date: Tue, 12 Dec 2023 12:46:25 +0100
Message-ID: <170238158532.8914.3985835992530527849@lain.khirnov.net> (raw)
In-Reply-To: <21696c17-4aa6-4e68-8a8e-b4d5d1c2773b@gmail.com>
Quoting James Almer (2023-12-11 13:53:40)
> On 12/11/2023 8:03 AM, Anton Khirnov wrote:
> > Quoting James Almer (2023-12-05 23:43:56)
> >> +/**
> >> + * Remove a stream group from its AVFormatContext and free it.
> >> + * The group must be the last stream of the AVFormatContext.
> >> + */
> >> +void ff_remove_stream_group(AVFormatContext *s, AVStreamGroup *stg);
> >
> > When would this be useful?
>
> I can't think of a use case right now, at least for the raw iamf demuxer
> and mp4 implementations. I added it for feature parity with AVStream and
> because it was four lines long.
Removing streams seems like a disgusting hack with very limited usage,
that should really not exist.
I'd rather not pretend we support removing previously added groups,
unless there is a very strong case for it.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-12 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 22:43 [FFmpeg-devel] [PATCH v6 0/8] " James Almer
2023-12-05 22:43 ` [FFmpeg-devel] [PATCH 1/8] avutil: introduce an Immersive Audio Model and Formats API James Almer
2023-12-11 10:19 ` Anton Khirnov
2023-12-05 22:43 ` [FFmpeg-devel] [PATCH 2/8] avformat: introduce AVStreamGroup James Almer
2023-12-11 10:59 ` Anton Khirnov
2023-12-11 12:48 ` James Almer
2023-12-11 12:51 ` Anton Khirnov
2023-12-11 11:03 ` Anton Khirnov
2023-12-11 12:53 ` James Almer
2023-12-12 11:46 ` Anton Khirnov [this message]
2023-12-05 22:43 ` [FFmpeg-devel] [PATCH 3/8] ffmpeg: add support for muxing AVStreamGroups James Almer
2023-12-11 11:48 ` Anton Khirnov
2023-12-11 12:46 ` James Almer
2023-12-12 11:26 ` Anton Khirnov
2023-12-05 22:43 ` [FFmpeg-devel] [PATCH 4/8] avcodec/packet: add IAMF Parameters side data types James Almer
2023-12-05 22:43 ` [FFmpeg-devel] [PATCH 5/8] avcodec/get_bits: add get_leb() James Almer
2023-12-05 22:44 ` [FFmpeg-devel] [PATCH 6/8] avformat/aviobuf: add ffio_read_leb() and ffio_write_leb() James Almer
2023-12-05 22:44 ` [FFmpeg-devel] [PATCH 7/8] avformat: Immersive Audio Model and Formats demuxer James Almer
2023-12-05 22:44 ` [FFmpeg-devel] [PATCH 8/8] avformat: Immersive Audio Model and Formats muxer James Almer
2023-12-10 21:52 ` [FFmpeg-devel] [PATCH v6 0/8] avformat: introduce AVStreamGroup James Almer
2023-12-14 20:14 [FFmpeg-devel] [PATCH v7 " James Almer
2023-12-14 20:14 ` [FFmpeg-devel] [PATCH 2/8] " James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170238158532.8914.3985835992530527849@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git