From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 92B85481BB for ; Tue, 12 Dec 2023 11:26:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2323668D165; Tue, 12 Dec 2023 13:26:36 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D0EB868D102 for ; Tue, 12 Dec 2023 13:26:29 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 981512405ED for ; Tue, 12 Dec 2023 12:26:29 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Otspt5sR3XG0 for ; Tue, 12 Dec 2023 12:26:29 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 246EC2400AC for ; Tue, 12 Dec 2023 12:26:29 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 11D001601B9; Tue, 12 Dec 2023 12:26:29 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20231205224402.14540-1-jamrial@gmail.com> <20231205224402.14540-4-jamrial@gmail.com> <170229528332.8914.3392013065667453741@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 12 Dec 2023 12:26:29 +0100 Message-ID: <170238038904.8914.1188169367703358247@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/8] ffmpeg: add support for muxing AVStreamGroups X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-12-11 13:46:36) > AVStreamGroup.type is not setteable through AVOptions, but it of course > needs to be supported by the CLI. So i catch it and remove it from the > dict that will be used for avformat_stream_group_create(). > > I can change the comment to "'type' is not a user settable AVOption". That seems better, thanks. > > 3) Print the string, not the index. > > > >> + ret = AVERROR(EINVAL); > >> + goto end; > >> + } > >> + > >> + ret = av_opt_eval_int(&pclass, opts, e->value, &type); > >> + if (ret < 0 || type == AV_STREAM_GROUP_PARAMS_NONE) { > >> + av_log(mux, AV_LOG_ERROR, "Invalid group type \"%s\"\n", e->value); > >> + goto end; > >> + } > >> + > >> + av_dict_copy(&tmp, dict, 0); > >> + stg = avformat_stream_group_create(oc, type, &tmp); > >> + if (!stg) { > >> + ret = AVERROR(ENOMEM); > >> + goto end; > >> + } > >> + av_dict_set(&tmp, "type", NULL, 0); > >> + > >> + e = NULL; > >> + while (e = av_dict_get(dict, "st", e, 0)) { > >> + unsigned int idx = strtol(e->value, NULL, 0); > >> + if (idx >= oc->nb_streams) { > >> + av_log(mux, AV_LOG_ERROR, "Invalid stream index %d\n", idx); > >> + ret = AVERROR(EINVAL); > >> + goto end; > >> + } > > > > This block seems confused about signedness of e->value. > > You mean change %d to %u? I mean strtol will parse the string into a signed number, then you assign the result into unsigned, and print it as signed. It's probably more user-friendly to keep parsing it as signed, and add a check for idx >= 0. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".