From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 05EA848579 for ; Thu, 7 Dec 2023 16:02:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0CF5668CF6C; Thu, 7 Dec 2023 18:02:48 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0ACFC68CC4A for ; Thu, 7 Dec 2023 18:02:42 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2A1342405EF; Thu, 7 Dec 2023 17:02:41 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id QHV_3hUwDEzg; Thu, 7 Dec 2023 17:02:40 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BAD752405ED; Thu, 7 Dec 2023 17:02:40 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id DF4701601B9; Thu, 7 Dec 2023 17:02:34 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231109122534.124157-8-ffmpeg@haasn.xyz> References: <20231109122534.124157-1-ffmpeg@haasn.xyz> <20231109122534.124157-8-ffmpeg@haasn.xyz> Mail-Followup-To: FFmpeg development discussions and patches , Niklas Haas Date: Thu, 07 Dec 2023 17:02:34 +0100 Message-ID: <170196495489.8914.9593124127809237771@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 07/25] vf_scale: use colorspace negotiation API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Niklas Haas (2023-11-09 13:19:39) > From: Niklas Haas > > This filter will always accept any input format, even if the user sets > a specific in_range/in_color_matrix. This is to preserve status quo with > current behavior, where passing a specific in_color_matrix merely > overrides the incoming frames' attributes. (Use `vf_format` to force > a specific input range) > > Because changing colorspace and color_range now requires reconfiguring > the link, we can lift sws_setColorspaceDetails out of scale_frame and > into config_props. (This will also get re-called if the input frame > properties change) > --- > libavfilter/vf_scale.c | 188 ++++++++++++++++++++++------------------- > 1 file changed, 103 insertions(+), 85 deletions(-) Can't say I understand all the code in detail, but looks generally reasonable. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".