From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 470FC46CE0 for ; Thu, 7 Dec 2023 07:17:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12B3068CDBB; Thu, 7 Dec 2023 09:17:47 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 043EE68BDB0 for ; Thu, 7 Dec 2023 09:17:40 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id AD60B2405ED for ; Thu, 7 Dec 2023 08:17:40 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id W7ENDPs3SeRb for ; Thu, 7 Dec 2023 08:17:40 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 079542400AC for ; Thu, 7 Dec 2023 08:17:40 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D996D1601B9; Thu, 7 Dec 2023 08:17:39 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <34689f2c-7986-4e87-a1b5-4c4378fc00c3@gmail.com> References: <20231202155352.4680-1-anton@khirnov.net> <34689f2c-7986-4e87-a1b5-4c4378fc00c3@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 07 Dec 2023 08:17:39 +0100 Message-ID: <170193345986.8914.7264991597427820027@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-12-06 21:49:45) > On 12/2/2023 12:53 PM, Anton Khirnov wrote: > > Its author not only failed to add any tests, as is required by the > > development rules, but continues to actively refuse to do so. > > > > Untested decoders are worse than useless, so remove it. > > --- > > Changelog | 2 +- > > libavcodec/Makefile | 1 - > > libavcodec/allcodecs.c | 1 - > > libavcodec/qoadec.c | 170 ----------------------------------------- > > 4 files changed, 1 insertion(+), 173 deletions(-) > > delete mode 100644 libavcodec/qoadec.c > > As there are tests now afaics, this patch can be withdrawn. Of course, actually pushing it was never the point of this patch. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".