From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 13/13 v2] fftools/ffmpeg: convert to a threaded architecture
Date: Thu, 30 Nov 2023 14:34:59 +0100
Message-ID: <170135129961.8914.10968061903168088055@lain.khirnov.net> (raw)
In-Reply-To: <20231130130826.GP3543730@pb2>
Quoting Michael Niedermayer (2023-11-30 14:08:26)
> On Sat, Nov 25, 2023 at 09:32:06PM +0100, Anton Khirnov wrote:
> > Change the main loop and every component (demuxers, decoders, filters,
> > encoders, muxers) to use the previously added transcode scheduler. Every
> > instance of every such component was already running in a separate
> > thread, but now they can actually run in parallel.
> >
> > Changes the results of ffmpeg-fix_sub_duration_heartbeat - tested by
> > JEEB to be more correct and deterministic.
> > ---
> > fftools/ffmpeg.c | 374 +--------
> > fftools/ffmpeg.h | 97 +--
> > fftools/ffmpeg_dec.c | 321 ++------
> > fftools/ffmpeg_demux.c | 268 ++++---
> > fftools/ffmpeg_enc.c | 368 ++-------
> > fftools/ffmpeg_filter.c | 722 +++++-------------
> > fftools/ffmpeg_mux.c | 324 ++------
> > fftools/ffmpeg_mux.h | 24 +-
> > fftools/ffmpeg_mux_init.c | 88 +--
> > fftools/ffmpeg_opt.c | 6 +-
> > .../fate/ffmpeg-fix_sub_duration_heartbeat | 36 +-
> > 11 files changed, 598 insertions(+), 2030 deletions(-)
>
> I tried
> ./ffmpeg -f lavfi -i testsrc2 -bsf:v noise -bitexact -t 2 /tmp/.y4m
>
> with merged ffmpeg_threading into master
>
> and it gets stuck
>
> Stream #0:0 -> #0:0 (wrapped_avframe (native) -> wrapped_avframe (native))
> Press [q] to stop, [?] for help
> [noise @ 0x55e8fbaea340] Wrapped AVFrame noising is unsupported
> [vost#0:0/wrapped_avframe @ 0x55e8fbae9840] Error initializing bitstream filter: noise
> [vf#0:0 @ 0x55e8fbaea880] Error sending frames to consumers: Not yet implemented in FFmpeg, patches welcome
> [vf#0:0 @ 0x55e8fbaea880] Task finished with error code: -1163346256 (Not yet implemented in FFmpeg, patches welcome)
> [vf#0:0 @ 0x55e8fbaea880] Terminating thread with return code -1163346256 (Not yet implemented in FFmpeg, patches welcome)
Sorry, seems I forgot to update my branch. Did that now, it should not
get suck anymore.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-30 13:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 19:14 [FFmpeg-devel] [PATCH v2] ffmpeg CLI multithreading Anton Khirnov
2023-11-23 19:14 ` [FFmpeg-devel] [PATCH 01/13] lavfi/buffersink: avoid leaking peeked_frame on uninit Anton Khirnov
2023-11-23 22:16 ` Paul B Mahol
2023-11-27 9:45 ` Nicolas George
2023-11-23 19:14 ` [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust Anton Khirnov
2023-11-27 9:40 ` Nicolas George
2023-11-27 9:42 ` Nicolas George
2023-11-27 13:02 ` Paul B Mahol
2023-11-27 13:49 ` Nicolas George
2023-11-27 14:08 ` Paul B Mahol
2023-11-29 10:18 ` Anton Khirnov
2023-11-23 19:14 ` [FFmpeg-devel] [PATCH 03/13] fftools/ffmpeg_filter: track input/output index in {Input, Output}FilterPriv Anton Khirnov
2023-11-23 19:14 ` [FFmpeg-devel] [PATCH 04/13] fftools/ffmpeg: make sure FrameData is writable when we modify it Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread Anton Khirnov
2023-11-24 22:56 ` Michael Niedermayer
2023-11-25 20:18 ` [FFmpeg-devel] [PATCH 05/13 v2] " Anton Khirnov
2023-11-25 20:23 ` [FFmpeg-devel] [PATCH 05/13] " James Almer
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 06/13] fftools/ffmpeg_filter: buffer sub2video heartbeat frames like other frames Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 07/13] fftools/ffmpeg_filter: reindent Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 08/13] fftools/ffmpeg_mux: add muxing thread private data Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 09/13] fftools/ffmpeg_mux: move bitstream filtering to the muxer thread Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 10/13] fftools/ffmpeg_demux: switch from AVThreadMessageQueue to ThreadQueue Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 11/13] fftools/ffmpeg_enc: move encoding to a separate thread Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 12/13] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure Anton Khirnov
2023-11-23 19:15 ` [FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg: convert to a threaded architecture Anton Khirnov
2023-11-24 22:26 ` Michael Niedermayer
2023-11-25 20:32 ` [FFmpeg-devel] [PATCH 13/13 v2] " Anton Khirnov
2023-11-30 13:08 ` Michael Niedermayer
2023-11-30 13:34 ` Anton Khirnov [this message]
2023-11-30 20:48 ` Michael Niedermayer
2023-12-01 11:15 ` [FFmpeg-devel] [PATCH 13/13 v3] " Anton Khirnov
2023-12-01 14:24 ` Nicolas George
2023-12-01 14:27 ` Anton Khirnov
2023-12-01 14:42 ` Nicolas George
2023-12-01 14:46 ` Anton Khirnov
2023-12-01 14:50 ` Nicolas George
2023-12-01 14:58 ` Anton Khirnov
2023-12-01 15:25 ` Nicolas George
2023-12-01 19:49 ` Anton Khirnov
2023-12-04 15:25 ` Nicolas George
2023-12-04 16:25 ` Anton Khirnov
2023-12-04 16:37 ` Nicolas George
2023-12-04 17:07 ` Anton Khirnov
2023-12-06 12:55 ` Nicolas George
2023-12-06 13:21 ` James Almer
2023-12-06 13:38 ` Nicolas George
2023-12-07 17:26 ` Paul B Mahol
2023-12-21 11:53 ` Paul B Mahol
2023-12-22 10:26 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170135129961.8914.10968061903168088055@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git