From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5D9E447A56 for ; Wed, 29 Nov 2023 10:18:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D13A568D026; Wed, 29 Nov 2023 12:18:15 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C48A668CEAF for ; Wed, 29 Nov 2023 12:18:08 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 14F042405ED for ; Wed, 29 Nov 2023 11:18:08 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id meFiJs7SrKBq for ; Wed, 29 Nov 2023 11:18:07 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9AF6524043D for ; Wed, 29 Nov 2023 11:18:07 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 802191601B9; Wed, 29 Nov 2023 11:18:01 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20231123191524.11296-2-anton@khirnov.net> <20231123191524.11296-4-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 29 Nov 2023 11:18:01 +0100 Message-ID: <170125308150.8914.17350993758974993386@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 02/13] fftools/ffmpeg_filter: make sub2video heartbeat more robust X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-11-27 10:40:18) > Anton Khirnov (12023-11-23): > > Avoid making decisions based on current graph input state, which makes > > the output dependent on the order in which the frames from different > > inputs are interleaved. > > > > Makes the output of fate-filter-overlay-dvdsub-2397 more correct - the > > subtitle appears two frames later, which is closer to its PTS as stored > > in the file. > > --- > > fftools/ffmpeg_filter.c | 3 +-- > > tests/ref/fate/filter-overlay-dvdsub-2397 | 4 ++-- > > tests/ref/fate/sub2video | 8 +++++--- > > 3 files changed, 8 insertions(+), 7 deletions(-) > > Just as I warned you, it breaks the test case I suggested: > > ./ffmpeg_g -xerror -i /tmp/dummy_with_sub.mkv -preset ultrafast -lavfi '[0:s]setpts=PTS+60/TB[s] ; [0:v][s]overlay' -y /tmp/dummy_with_hardsub.mkv > > (/tmp/dummy_with_sub.mkv is created like I told a few days ago) > thousands of frame queued, eventually failing on OOM. You're offsetting two streams from the same file by 60 seconds, so you should expect about 60s of buffering - that is 1500 frames at 25fps. The maximum amount of frames I see buffered is 1602, which roughly corresponds to the expected number. So I don't think this demonstrates there actually is a problem. Also note that the output timestamps look better after the patch than before. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".