From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E73AC48325 for ; Mon, 27 Nov 2023 16:56:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFFB068CF2C; Mon, 27 Nov 2023 18:56:33 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5FF0D68CEEE for ; Mon, 27 Nov 2023 18:56:27 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0E4732405ED; Mon, 27 Nov 2023 17:56:27 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id RcggyY4sQ7qj; Mon, 27 Nov 2023 17:56:24 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D476024043D; Mon, 27 Nov 2023 17:56:24 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id C19291601B9; Mon, 27 Nov 2023 17:56:24 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231109122534.124157-3-ffmpeg@haasn.xyz> References: <20231109122534.124157-1-ffmpeg@haasn.xyz> <20231109122534.124157-3-ffmpeg@haasn.xyz> Mail-Followup-To: FFmpeg development discussions and patches , Niklas Haas Date: Mon, 27 Nov 2023 17:56:24 +0100 Message-ID: <170110418476.8914.3276663840182900798@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 02/25] avfilter: always call ff_default_query_formats X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Niklas Haas (2023-11-09 13:19:34) > From: Niklas Haas > > Even if a query func is set. This is safe to do, because > ff_default_query_formats is documented not to touch any filter lists > that were already set by the query func. > > The reason to do this is because it allows us to extend > AVFilterFormatsConfig without having to touch every filter in existence. > An alternative implementation of this commit would be to explicitly add > a `ff_default_query_formats` call at the end of every query_formats > function, but that would end up functionally equivalent to this change > while touching a whole lot more code paths for no reason. > > As a bonus, eliminates some code/logic duplication from this function. > --- > libavfilter/avfiltergraph.c | 39 ++++++++++++------------------------- > 1 file changed, 12 insertions(+), 27 deletions(-) Looks ok. I'm also wondering whether we could/should now remove all ff_default_query_formats() calls from the filters and make that function filtergraph-only. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".