From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id ECF81471B7
	for <ffmpegdev@gitmailbox.com>; Mon, 27 Nov 2023 08:37:54 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 44FB168CF88;
	Mon, 27 Nov 2023 10:37:52 +0200 (EET)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C278068CF5B
 for <ffmpeg-devel@ffmpeg.org>; Mon, 27 Nov 2023 10:37:45 +0200 (EET)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 77D182404B1;
 Mon, 27 Nov 2023 09:37:45 +0100 (CET)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP
 id 2fuT9jYosIpE; Mon, 27 Nov 2023 09:37:44 +0100 (CET)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id D20EF24043D;
 Mon, 27 Nov 2023 09:37:44 +0100 (CET)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id A98971601B9; Mon, 27 Nov 2023 09:37:38 +0100 (CET)
From: Anton Khirnov <anton@khirnov.net>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>,
 "Xiang, Haihao" <haihao.xiang@intel.com>
In-Reply-To: <43a7ea159ce58594cca74e8a89f10e9a237366ed.camel@intel.com>
References: <20231124061736.170131-1-haihao.xiang@intel.com>
 <170099615667.8914.1178776596899788396@lain.khirnov.net>
 <43a7ea159ce58594cca74e8a89f10e9a237366ed.camel@intel.com>
Mail-Followup-To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>,
	"Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
Date: Mon, 27 Nov 2023 09:37:38 +0100
Message-ID: <170107425866.1197.13947716271182879266@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: ignore nonexistent
 device in default DRM device selection
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/170107425866.1197.13947716271182879266@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Xiang, Haihao (2023-11-27 05:42:20)
> > 
> > Also, the else is unnecessary since the if() block ends with continue.
> > 
> 
> I wanted to print a message if all devices don't exist. I'll remove it in the
> new version if you think such info is unnecessary. 

I don't object to the message, I mean just that

if (foo) {
  ....
  continue;
} else
  bar;

is equivalent to

if (foo) {
  ....
  continue;
}

bar;

The latter saves you one level of indentation and I find it more
readable.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".