From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24
Date: Sun, 26 Nov 2023 11:29:54 +0100
Message-ID: <170099459452.8914.17565921942167805253@lain.khirnov.net> (raw)
In-Reply-To: <1b426840-6c23-4bb2-8b86-30b1b83105f6@gmail.com>
Quoting James Almer (2023-11-24 22:03:29)
> On 11/24/2023 6:01 PM, Michael Niedermayer wrote:
> > On Wed, Nov 22, 2023 at 04:49:13PM -0300, James Almer wrote:
> >> Should simplify asm implementations, and prevent UB on at least win64.
> >>
> >> Signed-off-by: James Almer <jamrial@gmail.com>
> >> ---
> >> libavcodec/ac3dsp.c | 2 +-
> >> libavcodec/ac3dsp.h | 2 +-
> >> libavcodec/arm/ac3dsp_init_arm.c | 2 +-
> >> libavcodec/mips/ac3dsp_mips.c | 2 +-
> >> libavcodec/x86/ac3dsp_init.c | 4 ++--
> >> 5 files changed, 6 insertions(+), 6 deletions(-)
> >
> > In file included from src/libavcodec/mips/ac3dsp_mips.c:57:0:
> > src/libavcodec/ac3dsp.h:56:62: error: unknown type name ‘size_t’; did you mean ‘__ssize_t’?
> > void (*float_to_fixed24)(int32_t *dst, const float *src, size_t len);
> > ^~~~~~
> > __ssize_t
> > src/ffbuild/common.mak:81: recipe for target 'libavcodec/mips/ac3dsp_mips.o' failed
> > make: *** [libavcodec/mips/ac3dsp_mips.o] Error 1
> > make: *** Waiting for unfinished jobs....
> > mips FAIL
>
> Do you know where is size_t defined for this target? stddef.h?
size_t should _always_ be defined in stddef.h, as per C99 7.17.2
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-11-26 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 19:49 [FFmpeg-devel] [PATCH 1/3] x86/ac3dsp: reduce instruction count inside the float_to_fixed24 loop James Almer
2023-11-22 19:49 ` [FFmpeg-devel] [PATCH 2/3] x86/ac3dsp: add ff_float_to_fixed24_avx2() James Almer
2023-11-23 6:56 ` Kieran Kunhya
2023-11-23 11:51 ` James Almer
2023-11-23 15:19 ` Henrik Gramner via ffmpeg-devel
2023-11-22 19:49 ` [FFmpeg-devel] [PATCH 3/3] avcodec/ac3dsp: make len a size_t in float_to_fixed24 James Almer
2023-11-22 20:05 ` Rémi Denis-Courmont
2023-11-24 21:01 ` Michael Niedermayer
2023-11-24 21:03 ` James Almer
2023-11-24 23:49 ` Michael Niedermayer
2023-11-26 10:29 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170099459452.8914.17565921942167805253@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git