From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id B53014CBEC
	for <ffmpegdev@gitmailbox.com>; Sat, 12 Apr 2025 00:19:21 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 805A768BB4E;
	Sat, 12 Apr 2025 03:19:17 +0300 (EEST)
Received: from btbn.de (btbn.de [144.76.60.213])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07E44687CB9
 for <ffmpeg-devel@ffmpeg.org>; Sat, 12 Apr 2025 03:19:10 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id
 6A5AE281911DA
 for <ffmpeg-devel@ffmpeg.org>; Sat, 12 Apr 2025 02:19:07 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1744417147;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=jziZUyQrCuAw6AVf3wn9MQjqrogDyXT/Y+wdC+JlZQ0=;
 b=f3K1fUw/rKhzFHX1Vr2V7GjstDxu4HZ6TSUkZqERUJGNVh2iXjZxzhmVQgOlmUPqszJ8M/
 Pt7sqve65mxAfWiXLcz+dtnVZxD5LaT/LjuuC9Al0uK/hgdq8oEJCMAgA7yBGemwj+hn4y
 xpCwHmhDO23Krj8X9Hur5SkT7MF7GRjSCbQBZVu3uAIsGHZAST4RLACNf6Mxd9KZlzKZIr
 CjwKB9Ov+UvypUAjWk0/iC9Fe7es8zTpGInRxaxnYPz28XN+KvL11/LBb75YX0rVSmUCQW
 hR3gGkbZF+2ebuBRV3qz9jz0HZTBJ41tpJ0if1OcdewxIcGwLYCytSBkKZlAUw==
Message-ID: <16bef658-ba7c-48ff-b7fd-f9d449488f49@rothenpieler.org>
Date: Sat, 12 Apr 2025 02:19:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20250410170504.308400-1-michael@niedermayer.cc>
 <GV1P250MB073772D581844374C47913578FB62@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
 <20250412001132.GF4991@pb2>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <20250412001132.GF4991@pb2>
Subject: Re: [FFmpeg-devel] [PATCH v2] configure: Clearer documentation for
 "disable-safe-bitstream-reader"
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/16bef658-ba7c-48ff-b7fd-f9d449488f49@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 12.04.2025 02:11, Michael Niedermayer wrote:
> On Fri, Apr 11, 2025 at 08:32:55AM +0200, Andreas Rheinhardt wrote:
>> Michael Niedermayer:
>>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>>> ---
>>>   configure | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index bd4f8723760..f1db8b6f235 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -436,7 +436,8 @@ Advanced options (experts only):
>>>     --enable-hardcoded-tables use hardcoded tables instead of runtime generation
>>>     --disable-safe-bitstream-reader
>>>                              disable buffer boundary checking in bitreaders
>>> -                           (faster, but may crash)
>>> +                           (This disables some security checks and can cause undefined behavior,
>>> +                            it may be faster, but should only be used with trusted input)
>>>     --sws-max-filter-size=N  the max filter size swscale uses [$sws_max_filter_size_default]
>>>   
>>>   Optimization options (experts only):
>>
>> I'd like to keep "crash" in the description. Not everyone (not even
>> people setting "experts only" options) will be familiar with the term
>> "undefined behavior".
> 
> what about:
> 
> (This disables some security checks and can cause undefined behavior and
>   crashes, it may be faster, but should only be used with trusted input)

Given that the undefined behaviour can in theory even include arbitrary 
code execution, I'd probably make it even harsher and mention that 
worst-case being a possibility.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".