From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA20D48076 for ; Thu, 9 Nov 2023 11:06:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4B9768CB7F; Thu, 9 Nov 2023 13:06:19 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9811668C39B for ; Thu, 9 Nov 2023 13:06:13 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 49F3E2404B1 for ; Thu, 9 Nov 2023 12:06:13 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 53geanSc8gIR for ; Thu, 9 Nov 2023 12:06:11 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0A78624043D for ; Thu, 9 Nov 2023 12:06:11 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id E3E7A1601B9; Thu, 9 Nov 2023 12:06:10 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-19-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 09 Nov 2023 12:06:10 +0100 Message-ID: <169952797090.11195.9598759007205399574@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 18/24] fftools/ffmpeg: add thread-aware transcode scheduling infrastructure X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-11-04 14:53:25) > On 11/4/2023 4:56 AM, Anton Khirnov wrote: > > +static void *task_wrapper(void *arg) > > +{ > > + SchTask *task = arg; > > + Scheduler *sch = task->parent; > > + int ret; > > + int err = 0; > > + > > + ret = (intptr_t)task->func(task->func_arg); > > + if (ret < 0) > > + av_log(task->func_arg, AV_LOG_ERROR, > > + "Task finished with error code: %d (%s)\n", ret, av_err2str(ret)); > > + > > + switch (task->node.type) { > > + case SCH_NODE_TYPE_DEMUX: err = demux_done (sch, task->node.idx); break; > > + case SCH_NODE_TYPE_MUX: err = mux_done (sch, task->node.idx); break; > > + case SCH_NODE_TYPE_DEC: err = dec_done (sch, task->node.idx); break; > > + case SCH_NODE_TYPE_ENC: err = enc_done (sch, task->node.idx); break; > > + case SCH_NODE_TYPE_FILTER_IN: err = filter_done(sch, task->node.idx); break; > > task->node.type seems to be constant, so wouldn't it be faster, This is only called once per node, so I don't think performance considerations make sense. > or at least cleaner looking here, to use a function pointer assigned > in task_init()? That just moves the switch to a different place, adds an extra function pointer, and makes it less clear what is being called, so I don't see how it's an improvement. That said, I do have some vague thoughts about abstracting away some node-type specific things, but I'd rather leave that for later. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".