From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00BE848073 for ; Thu, 9 Nov 2023 10:42:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B067568CB6C; Thu, 9 Nov 2023 12:42:49 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1C6C68C6F3 for ; Thu, 9 Nov 2023 12:42:42 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 683092404B1 for ; Thu, 9 Nov 2023 11:42:42 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id WInPFBw31V4W for ; Thu, 9 Nov 2023 11:42:42 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 00E8524043D for ; Thu, 9 Nov 2023 11:42:41 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D061D1601B9; Thu, 9 Nov 2023 11:42:41 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20231104092125.10213-1-anton@khirnov.net> <20231104092125.10213-9-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 09 Nov 2023 11:42:41 +0100 Message-ID: <169952656183.11195.3322106643898810523@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 08/24] fftools/ffmpeg_filter: remove an unnecessary sub2video_push_ref() call X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-11-04 15:19:00) > Anton Khirnov (12023-11-04): > > It only seems to produce duplicate frames. > > Yes it does, that is the point of it. Without the duplicated frame, a > filter with synchronized inputs (like overlay) will accumulate video > frames while waiting for the next sub2video frame. The problem with that code (and the reason this patch exists), is that it depends on the order in which the frames arrive on filtergraph inputs, which is not meaningful (and becomes non-deterministic with threading). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".