From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 359FA48019 for ; Wed, 8 Nov 2023 16:50:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3B4D68CB18; Wed, 8 Nov 2023 18:50:12 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4AB4D68C8BE for ; Wed, 8 Nov 2023 18:50:06 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 086A324072E for ; Wed, 8 Nov 2023 16:32:45 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Jf5eUR-lnoNY for ; Wed, 8 Nov 2023 16:32:44 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6707C2406CA for ; Wed, 8 Nov 2023 16:32:44 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 4B8DA1601B9; Wed, 8 Nov 2023 16:32:44 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <03aae8d1-edc7-4bb8-b2c8-23ac49c665c0@gmail.com> References: <03aae8d1-edc7-4bb8-b2c8-23ac49c665c0@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 08 Nov 2023 16:32:44 +0100 Message-ID: <169945756428.11195.9541957023465587702@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavformat: increase MAX_URL_SIZE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting WooDzu (2023-10-28 15:04:38) > With the rise of object storage, like S3, it is not uncommon to generate > long pre-signed URLs. When a pre-signed URL is generated using a > short-lived credentials it may include a query parameter called > X-Amz-Security-Token that is 4kB on its own. > The current MAX_URL_SIZE will trim the URL with no any errors or > warnings and the request will fail with a http 400 error. Why do we have a static limit in the first place? Wouldn't it be better to make the relevant strings dynamically allocated? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".