From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6771147A06 for ; Sun, 29 Oct 2023 09:13:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A866068CA4B; Sun, 29 Oct 2023 11:13:37 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 385AD68C273 for ; Sun, 29 Oct 2023 11:13:31 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B7E022405ED for ; Sun, 29 Oct 2023 10:13:30 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id R1y4fjphudCM for ; Sun, 29 Oct 2023 10:13:28 +0100 (CET) Received: from lain.khirnov.net (unknown [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6940E24043D for ; Sun, 29 Oct 2023 10:13:28 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id BB8431601B9; Sun, 29 Oct 2023 10:13:19 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231023232346.8813-1-jamrial@gmail.com> References: <20231023232346.8813-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 29 Oct 2023 10:13:19 +0100 Message-ID: <169857079974.11195.3253795192191104914@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/channel_layout: rename 7.1(top) channel layout to 5.1.2 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-10-24 01:23:44) > This layout maps to ITU-R BS.2051-3 "Sound System C" and ITU-R BS.1196-8 "Channel > Configuration 14", and it being the first layout with top layer channels, it's > best to use a different scheme to properly convey the presence and amount of said > channels. > The new name will also be a better fit for the additions in the following commits. > > Signed-off-by: James Almer > --- > doc/utils.texi | 2 +- > libavutil/channel_layout.c | 2 +- > libavutil/channel_layout.h | 8 ++++++-- > tests/ref/fate/channel_layout | 2 +- > 4 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/doc/utils.texi b/doc/utils.texi > index 8e8bfa76d4..1388e5dabe 100644 > --- a/doc/utils.texi > +++ b/doc/utils.texi > @@ -713,7 +713,7 @@ FL+FR+FC+LFE+BL+BR+SL+SR > FL+FR+FC+LFE+BL+BR+FLC+FRC > @item 7.1(wide-side) > FL+FR+FC+LFE+FLC+FRC+SL+SR > -@item 7.1(top) > +@item 5.1.2 > FL+FR+FC+LFE+BL+BR+TFL+TFR > @item octagonal > FL+FR+FC+BL+BR+BC+SL+SR > diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c > index 9b581ae6b3..b259e75d37 100644 > --- a/libavutil/channel_layout.c > +++ b/libavutil/channel_layout.c > @@ -200,7 +200,7 @@ static const struct channel_layout_name channel_layout_map[] = { > { "7.1", AV_CHANNEL_LAYOUT_7POINT1 }, > { "7.1(wide)", AV_CHANNEL_LAYOUT_7POINT1_WIDE_BACK }, > { "7.1(wide-side)", AV_CHANNEL_LAYOUT_7POINT1_WIDE }, > - { "7.1(top)", AV_CHANNEL_LAYOUT_7POINT1_TOP_BACK }, Doesn't this need deprecation? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".