From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4AEF5476C6 for ; Fri, 20 Oct 2023 13:54:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 517A168CAC9; Fri, 20 Oct 2023 16:54:25 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3B9668C9F3 for ; Fri, 20 Oct 2023 16:54:18 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 4553E240498 for ; Fri, 20 Oct 2023 15:54:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id WJYXpdOMOpWu for ; Fri, 20 Oct 2023 15:54:17 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9111B2400FF for ; Fri, 20 Oct 2023 15:54:17 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id B9ABF1601B9; Fri, 20 Oct 2023 15:54:16 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20231014134634.GC89414@haasn.xyz> References: <20231013142706.23971-1-ffmpeg@haasn.xyz> <20231013142706.23971-3-ffmpeg@haasn.xyz> <20231014134634.GC89414@haasn.xyz> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 20 Oct 2023 15:54:16 +0200 Message-ID: <169781005673.30698.11519230045707447960@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 02/13] avcodec: add extended AVCodec color metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Niklas Haas (2023-10-14 13:46:34) > > 3. I don't see how the MJPEG encoder behaviour where the valid formats > > de facto depend upon strictness can be encoded in this way; isn't the > > aim to get rid of the necessity of the workaround in ffmpeg cli? > > Note that ffmpeg cli presently initializes the filter graph well before > the AVCodecContext is set up with options, let alone opened. (Presently, > the logic for overriding the pixfmt list directly looks up the "strict" > field in the options dict) > > So that limits the design space somewhat for elegant solutions here. > Either we make the "return list of supported formats" callback in > AVCodec simply accept the strict_std_compliance setting directly, or we > extend the static list of colorspaces itself by an extra strictness > field. Probably the former is better than the latter of these two > approaches. FWIW I find that behaviour to be a disgusting hack and the cleanest way to address it would IMO be a separate mjpeg_experimental AVCodec instance. That is assuming anyone actually needs this functionality. Maybe we could also just drop it? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".