From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 70C3A40570 for <ffmpegdev@gitmailbox.com>; Fri, 20 Oct 2023 08:18:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E41C468CADA; Fri, 20 Oct 2023 11:18:24 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 658BF68C79C for <ffmpeg-devel@ffmpeg.org>; Fri, 20 Oct 2023 11:18:18 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 1161A240498 for <ffmpeg-devel@ffmpeg.org>; Fri, 20 Oct 2023 10:18:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 5SGew3TTXrls for <ffmpeg-devel@ffmpeg.org>; Fri, 20 Oct 2023 10:18:17 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 989842400FF for <ffmpeg-devel@ffmpeg.org>; Fri, 20 Oct 2023 10:18:17 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 83A981601B9; Fri, 20 Oct 2023 10:18:17 +0200 (CEST) From: Anton Khirnov <anton@khirnov.net> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> In-Reply-To: <GV1P250MB073710C040389D3EECB372378F29A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> References: <20230501114456.13898-1-epirat07@gmail.com> <20230625104907.53071-1-epirat07@gmail.com> <GV1P250MB073712CEA4422209BBD06C1B8F29A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <7D4C10CB-A3F9-4ECD-916B-417F3F538913@gmail.com> <GV1P250MB073710C040389D3EECB372378F29A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Mail-Followup-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Date: Fri, 20 Oct 2023 10:18:17 +0200 Message-ID: <169778989751.30698.15022276759252509666@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/dict: add av_dict_pop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/169778989751.30698.15022276759252509666@lain.khirnov.net/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Quoting Andreas Rheinhardt (2023-07-03 20:02:25) > Marvin Scholz: > > I honestly can't think of a sensible API design for this, > > if you have any idea feel free to share. > > > > The only way I can think of that allows this is for the user to pass a > pointer to a (const) AVDictionaryEntry, namely the entry that the user > wishes to pop. This is of course cumbersome, because it would be two > function calls. We could start guaranteeing that entries with the same key are always returned in insertion order. Now that I think of it there's some code in ffmpeg CLI that relies on that. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".